unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Danny Freeman <danny@dfreeman.email>
Cc: arash@gnu.org, arstoffel@gmail.com, 59338@debbugs.gnu.org
Subject: bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows
Date: Fri, 18 Nov 2022 16:35:05 +0200	[thread overview]
Message-ID: <83zgco9vqe.fsf@gnu.org> (raw)
In-Reply-To: <87wn7swf4e.fsf@dfreeman.email> (message from Danny Freeman on Fri, 18 Nov 2022 08:39:13 -0500)

> From: Danny Freeman <danny@dfreeman.email>
> Cc: Augusto Stoffel <arstoffel@gmail.com>, arash@gnu.org,
>  59338@debbugs.gnu.org, bug-gnu-emacs@gnu.org
> Date: Fri, 18 Nov 2022 08:39:13 -0500
> 
> The current eglot--path-to-uri implementation should produce a valid
> file:// url unless what it receives is already a URL.
> 
> So it could receive something like:
> 
> /home/user/project/whatever.c
> d:/what/home/is/on/windows/whatever.c
> 
> Both of which should be transformed into file:// URLs
> OR what it receives may already be a URL like
> 
> zipfile:home/user/project.zip::/path/in/zip.c
> 
> If it receives a URL, we want to pass it along, and not transform it
> into a file:// URL.
> 
> If it is a full windows path, we DO want to turn that into a file url.
> 
> So how do we detect that is is a windows path, and not a URL already?

You test that system-type is windows-nt AND that the
file-name-absolute-p returns non-nil for the argument.





  reply	other threads:[~2022-11-18 14:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 16:51 bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows Arash Esbati
2022-11-17 17:06 ` Eli Zaretskii
2022-11-17 17:18   ` Augusto Stoffel
2022-11-17 22:27     ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-17 23:12       ` Augusto Stoffel
2022-11-18  7:14         ` Eli Zaretskii
2022-11-18 13:39           ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 14:35             ` Eli Zaretskii [this message]
2022-11-18 14:55               ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 20:01                 ` Arash Esbati
2022-11-18  7:12       ` Eli Zaretskii
2022-11-23 12:51         ` João Távora
2022-11-24 13:42           ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-24 15:27             ` João Távora
2022-11-17 22:33   ` Arash Esbati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zgco9vqe.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59338@debbugs.gnu.org \
    --cc=arash@gnu.org \
    --cc=arstoffel@gmail.com \
    --cc=danny@dfreeman.email \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).