From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59347: 29.0.50; `:family` face setting ignored Date: Sun, 20 Nov 2022 19:29:29 +0200 Message-ID: <83zgcl4jra.fsf@gnu.org> References: <83bkp4bfqf.fsf@gnu.org> <83wn7s9txp.fsf@gnu.org> <83pmdk9pat.fsf@gnu.org> <83cz9j9zyu.fsf@gnu.org> <838rk77yfo.fsf@gnu.org> <834juu9aya.fsf@gnu.org> <7cc9e03786024fc72f3b@heytings.org> <83a64l65ai.fsf@gnu.org> <7cc9e0378678a092e6ee@heytings.org> <835yf962q4.fsf@gnu.org> <7cc9e03786754c9e0aaf@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35934"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 59347@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 20 18:30:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owo9B-00097n-Lv for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Nov 2022 18:30:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owo8s-0002zC-Qt; Sun, 20 Nov 2022 12:30:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owo8r-0002yS-8R for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 12:30:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owo8p-0000JH-PS for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 12:30:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owo8p-0002fL-DF for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 12:30:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Nov 2022 17:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59347 X-GNU-PR-Package: emacs Original-Received: via spool by 59347-submit@debbugs.gnu.org id=B59347.166896537010159 (code B ref 59347); Sun, 20 Nov 2022 17:30:03 +0000 Original-Received: (at 59347) by debbugs.gnu.org; 20 Nov 2022 17:29:30 +0000 Original-Received: from localhost ([127.0.0.1]:44478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owo8I-0002dn-5M for submit@debbugs.gnu.org; Sun, 20 Nov 2022 12:29:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owo8H-0002db-4G for 59347@debbugs.gnu.org; Sun, 20 Nov 2022 12:29:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owo8B-00006Y-0V; Sun, 20 Nov 2022 12:29:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NjlWi1U3RrKzqIqn5Hwiu0/JNlG2OZbLAEhmrUo2NcM=; b=ABgL06eVIxF/ OPkPZ+JMMUHRVN9/cQByJmElI71BLLQQ9igodLfyXfl2+RcF1KVcag/n71OHizcmkMrvILePoBNx+ ydBkeCcUonOg/XCHHCTCQz54QnCRvDIKKtsKPndrS+YmolGPBqVLDXDFJk1Wjt3BrmKw09i5yJk03 zIxuMWve9YfIrOMIKYD9U5qnPgVZUkhSxl639+ZORGCLgjjiilnbnM5tY17jhPZGnTH1RYcXO02Xc YWZzO2Q9l8CQkksysX35Dr8yxCfdWyLFowy/Dj864PYtjNBcf7HcXM1Z0LUTDFhIVG6wW9rtap8O+ MIe1jnUPBby6SL6goS8vBw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owo88-0007vO-Bu; Sun, 20 Nov 2022 12:29:22 -0500 In-Reply-To: <7cc9e03786754c9e0aaf@heytings.org> (message from Gregory Heytings on Sun, 20 Nov 2022 16:59:00 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248440 Archived-At: > Date: Sun, 20 Nov 2022 16:59:00 +0000 > From: Gregory Heytings > cc: monnier@iro.umontreal.ca, 59347@debbugs.gnu.org > > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59347#65 > > > > Thanks. What he describes there looks like a workaround more than a > solution to me. The actual problem is that > > -misc-fixed-*-r-semicondensed-*-13-*-*-*-*-*-*-* > > selects > > -misc-fixed-medium-r-semicondensed--13-120-75-75-c-60-iso8859-1 > > in which you see the 'medium' height. You mean weight, not height, right? Does this font have a 'regular' weight? If it does, why didn't Emacs choose the 'regular' variant? In any case, I don't understand how asking for a specific foundry can work around the problem with weight. If you do understand that, please tell the details. > > If we don't make font_score consistent with the change you made, we will > > have other weird problems. Maybe not in this particular case (although > > I'm not sure even in this), but in others. > > Thanks, I think I see what you mean now. I overlooked the fact that > font_select_entity is called with attrs and not with work, so indeed > font_score called in font_sort_entities might reject (?) a legitimate > font. Is that what you mean? Yes. We need to make sure the scoring will not now sometimes prefer the medium weight where the regular weight exists and is a better match. Not only should it not reject a legitimate font, but also not prefer another font due to this change. IOW, the change should ideally only affect the cases where the 'medium' weight doesn't exist, and we therefore prefer to use 'regular' rather than reject the family.