From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58919: 28.2; dired-copy-file-recursive fails to overwrite directory Date: Sun, 11 Dec 2022 12:46:22 +0200 Message-ID: <83zgbutdz5.fsf@gnu.org> References: <87y1sws6eq.fsf@posteo.net> <83wn8gdu4k.fsf@gnu.org> <31dc6bb7-ada3-aeac-c65b-d7de4a326026@cs.ucla.edu> <87k04ebhvn.fsf@gmx.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32582"; mail-complaints-to="usenet@ciao.gmane.io" Cc: thievol@posteo.net, 58919@debbugs.gnu.org, eggert@cs.ucla.edu To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 11:47:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4Jrn-0008GQ-BM for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 11:47:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4Jra-0003yg-CX; Sun, 11 Dec 2022 05:47:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4JrL-0003xx-1T for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 05:47:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4JrK-0007Dr-KF for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 05:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4JrK-0000F9-1L for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 05:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 10:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58919 X-GNU-PR-Package: emacs Original-Received: via spool by 58919-submit@debbugs.gnu.org id=B58919.1670755595926 (code B ref 58919); Sun, 11 Dec 2022 10:47:02 +0000 Original-Received: (at 58919) by debbugs.gnu.org; 11 Dec 2022 10:46:35 +0000 Original-Received: from localhost ([127.0.0.1]:46314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Jqs-0000Es-TJ for submit@debbugs.gnu.org; Sun, 11 Dec 2022 05:46:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Jqp-0000Em-0w for 58919@debbugs.gnu.org; Sun, 11 Dec 2022 05:46:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Jqh-00079n-P2; Sun, 11 Dec 2022 05:46:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ylL62UaIOTlQoiH0BW9ezP8BdRB/4SXAgu4hz3t/UEU=; b=r8xBLVALuAbp G/OlnyYC31lpckNOluZ2JialmY091wMFvijSl3kms8fknSzC5FGRsFOetjNAdk2e4vTI0mn8eir6q 39Rmpn8WAAUnmXdkkxX71V0AKqlkSFHjdtHufLClMem3uyazFUAOwGgVVQYVVyvXSIqEZ75Cm8Zeu KSQzWtvNODDW99FKNWQwjXnnAzQ6fv8ia8x5IqS7zsIWeWvs+KJQENUMJgqVxv3y7fIQRBQwBweqa E/KfDRasHcmI20hHxcqj2xm640VGUbrlI08V50cQu5Mnpu22Bb4XYYLpqZOcQB9mk80dv8G0nne/6 ufa2ZSh2dnK238xbRr3zOA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Jqh-00044q-3X; Sun, 11 Dec 2022 05:46:23 -0500 In-Reply-To: <87k04ebhvn.fsf@gmx.de> (message from Michael Albinus on Tue, 01 Nov 2022 20:21:32 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250592 Archived-At: Ping! Paul, did you have an opportunity to come up with the patch you mentioned in this discussion? I'd like to solve this bug for Emacs 29, please. > From: Michael Albinus > Date: Tue, 01 Nov 2022 20:21:32 +0100 > Cc: Thierry Volpiatto , 58919@debbugs.gnu.org, > Eli Zaretskii > > Paul Eggert writes: > > Hi Paul, > > > The simplest fix I can see is to enhance make-directory so that it > > returns t if the directory already existed and PARENTS was given, nil > > on any other successful return. This would require changes to Tramp to > > avoid races there. I plan to post a proposed patch for comment. > > To make it more fun, there are several Tramp implementations of that > function, and also other ones. Xref, running in the lisp/ tree for > "defun.*make-directory", returns > > --8<---------------cut here---------------start------------->8--- > lisp/dired.el > 1911: (defun dired--make-directory-clickable () > lisp/files.el > 6203: (defun make-directory (dir &optional parents) > lisp/gnus/gnus-group.el > 3120: (defun gnus-group-make-directory-group (dir) > lisp/gnus/gnus-util.el > 726: (defun gnus-make-directory (directory) > lisp/htmlfontify.el > 1844: (defun hfy-make-directory (dir) > lisp/ido.el > 2994: (defun ido-make-directory (&optional dir) > lisp/net/ange-ftp.el > 4125: (defun ange-ftp-make-directory (dir &optional parents) > 4530: (defun ange-ftp-real-make-directory (&rest args) > lisp/net/tramp-adb.el > 411: (defun tramp-adb-handle-make-directory (dir &optional parents) > lisp/net/tramp-crypt.el > 800: (defun tramp-crypt-handle-make-directory (dir &optional parents) > lisp/net/tramp-fuse.el > 128: (defun tramp-fuse-handle-make-directory (dir &optional parents) > lisp/net/tramp-gvfs.el > 1560: (defun tramp-gvfs-handle-make-directory (dir &optional parents) > lisp/net/tramp-sh.el > 2559: (defun tramp-sh-handle-make-directory (dir &optional parents) > lisp/net/tramp-smb.el > 1172: (defun tramp-smb-handle-make-directory (dir &optional parents) > 1192: (defun tramp-smb-handle-make-directory-internal (directory) > lisp/net/tramp-sudoedit.el > 626: (defun tramp-sudoedit-handle-make-directory (dir &optional parents) > lisp/obsolete/autoload.el > 725: (defun make-directory-autoloads (dir output-file) > lisp/url/url-dav.el > 761: (defun url-dav-make-directory (url &optional _parents) > --8<---------------cut here---------------end--------------->8--- > > Best regards, Michael. > > > >