From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60841: 30.0.50; kill-ring-save pauses despite region being highlighted Date: Sun, 29 Jan 2023 21:33:38 +0200 Message-ID: <83zga15e5p.fsf@gnu.org> References: <87h6wrs71h.fsf@gmail.com> <83zgai4peg.fsf@gnu.org> <5583fd58387746ce7ddc@heytings.org> <87cz7dbns0.fsf@gmail.com> <4c2c6cf44ad37e405b06@heytings.org> <878ri0g6ob.fsf@gmail.com> <83pmbc0yxo.fsf@gnu.org> <87y1pzo5dp.fsf@gmail.com> <834jskmhs8.fsf@gnu.org> <87fsc2qjcs.fsf@gmail.com> <833581jtff.fsf@gnu.org> <87lelsga1f.fsf@gmail.com> <83r0vkgj7l.fsf@gnu.org> <87h6wawo2k.fsf@gmail.com> <831qnea5ye.fsf@gnu.org> <87357t2xyh.fsf@gmail.com> <86ilgpb3lv.fsf@mail.linkov.net> <831qnd6tup.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29808"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org, 60841@debbugs.gnu.org, kevin.legouguec@gmail.com To: juri@linkov.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 29 20:34:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMDRP-0007WF-BO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Jan 2023 20:34:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMDRG-0008Jm-VM; Sun, 29 Jan 2023 14:34:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMDRD-0008Jc-7t for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 14:34:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMDRC-0007c0-Dg for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 14:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMDRB-0008Mx-RW for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 14:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 19:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60841 X-GNU-PR-Package: emacs Original-Received: via spool by 60841-submit@debbugs.gnu.org id=B60841.167502083732159 (code B ref 60841); Sun, 29 Jan 2023 19:34:01 +0000 Original-Received: (at 60841) by debbugs.gnu.org; 29 Jan 2023 19:33:57 +0000 Original-Received: from localhost ([127.0.0.1]:45426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMDR6-0008Mc-Sz for submit@debbugs.gnu.org; Sun, 29 Jan 2023 14:33:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMDR4-0008MP-Ul for 60841@debbugs.gnu.org; Sun, 29 Jan 2023 14:33:55 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMDQy-0007bM-L9; Sun, 29 Jan 2023 14:33:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=66VmD1EFhcDpin46EzYeXxlV09os8gDUHp9PClpFAT8=; b=bXHxLu/wVbGWpXaaGxlx HK8H+qJUX0DBRfsqex8IDqkJ/xraCF4G/JPCUPo8VZP8ZG3IpAHc8cgStLTjsj9l0MHuVCDtDD47U z3pIHs+ryejz6kTYZ2HptsFejXK8pCzmaHe0w6FuuR3H79Q7gZtvLmRYwR3BXOy1zxQIq8ItVjKdk xP9RD64gnic0qsrPfEzDisq6JY++cssr7iR00ahpWQduzWGHFKFEP5OHhTqnqjXQM69H+dyzb4Ak5 2vAJMe9QBkH5On99m5owtU/tBZKUZ4x91nXXjxefSkKk/JDERcGuI9DL0lWu6Ju2Ss3YKW5EeP70/ 58dqq+G4XS7RQQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMDQy-0007Vm-4n; Sun, 29 Jan 2023 14:33:48 -0500 In-Reply-To: <831qnd6tup.fsf@gnu.org> (message from Eli Zaretskii on Sun, 29 Jan 2023 21:09:18 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254379 Archived-At: > Cc: gregory@heytings.org, 60841@debbugs.gnu.org, kevin.legouguec@gmail.com > Date: Sun, 29 Jan 2023 21:09:18 +0200 > From: Eli Zaretskii > > > > 2. (face-differs-from-default-p list-matching-lines-prefix-face) > > > ↦ :stipple > > > > I still don't understand why (face-differs-from-default-p 'default) > > should return :stipple even in a clean state after emacs -Q. > > This means that the default face always differs from itself? > > Because face-differs-from-default-p thinks attributes are unset only > if their value is 'unspecified'. We should fix that so the function > knows about nil as well. I think face-differs-from-default-p should look like this: (defun face-differs-from-default-p (face &optional frame) "Return non-nil if FACE displays differently from the default face. If the optional argument FRAME is given, report on face FACE in that frame. If FRAME is t, report on the defaults for face FACE (for new frames). If FRAME is omitted or nil, use the selected frame." (let ((attrs (delq :inherit (delq :extend (mapcar 'car face-attribute-name-alist)))) (differs nil)) (while (and attrs (not differs)) (let* ((attr (pop attrs)) (attr-val (face-attribute face attr frame t))) (when (and (not (eq attr-val 'unspecified)) (not (equal attr-val (face-attribute 'default attr frame))) (display-supports-face-attributes-p (list attr attr-val) frame)) (setq differs attr)))) differs))