From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60983: 29.0.60; Tree-sitter user-level control Date: Sun, 05 Feb 2023 08:01:14 +0200 Message-ID: <83zg9sslat.fsf@gnu.org> References: <83tu0kkuqo.fsf@gnu.org> <7B62BDA1-C46B-4373-B3A7-2F9E34F3D803@gmail.com> <83tu03ur55.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23361"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60983@debbugs.gnu.org, theo@thornhill.no To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 05 07:02:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pOY6W-0005sz-Hg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Feb 2023 07:02:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOY6G-0002a8-Ps; Sun, 05 Feb 2023 01:02:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOY6E-0002Z1-JY for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 01:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pOY6E-0001ZM-9t for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 01:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pOY6E-0002s7-4e for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 01:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Feb 2023 06:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60983 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, theo@thornhill.no Original-Received: via spool by submit@debbugs.gnu.org id=B.167557687410962 (code B ref -1); Sun, 05 Feb 2023 06:02:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Feb 2023 06:01:14 +0000 Original-Received: from localhost ([127.0.0.1]:43822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOY5S-0002qk-5v for submit@debbugs.gnu.org; Sun, 05 Feb 2023 01:01:14 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:39346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOY5P-0002qX-8T for submit@debbugs.gnu.org; Sun, 05 Feb 2023 01:01:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOY5L-0002Pf-TO for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 01:01:08 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOY5K-0001NO-DJ; Sun, 05 Feb 2023 01:01:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=5ajwOKm2xqLzn8lBcgnHMgeeY39uzrJryDgHqhnQIqs=; b=jBmAwqoz63JOO5nddTkg fHVOZq+VxIeMkBN4zBRnpZqYMmkqSZHOLUE0QMCEvZ5dhwKbEFeYG28d/wwm9peJV9B1mAtWABWHN Sq6NHlGKOn8dtdmFqNSDUCj+I+pNCCxoKF1XiK/NPV0CC1QKxehRJNK9g2TM5MgCWUFGED9NFx53V nZeezDHD+3SjXNJdFW2xIt2eRDngR7OdDujDwLVElIB6xYrlKNR7xNxWzYc5hixedMWH5tqlBsjI+ GTj3XiuRzj/w1kALnqIcmQtzXLcYgO+7KYQEoBx7bgzssRVCJGwjWu9ht7jbqtc/+Aqcdudg/+frL FBEnydy3wjzvJQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOY5I-0006UN-T6; Sun, 05 Feb 2023 01:01:05 -0500 In-Reply-To: (message from Yuan Fu on Sat, 4 Feb 2023 15:38:17 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254814 Archived-At: > From: Yuan Fu > Date: Sat, 4 Feb 2023 15:38:17 -0800 > Cc: Bug Report Emacs , > theo@thornhill.no > > > treesit-font-lock-recompute-features is a non-interactive function, so > > mentioning it in the user manual is generally inappropriate. Users > > are unlikely to add features that aren't already defined in the mode's > > font-lock setup. > > > > This function and its use in these situations are described in the > > ELisp manual, where I think it belongs. > > > > As for the fact that changing treesit-font-lock-feature-list directly > > doesn't have any effect, that is already in the doc string. I'm not > > opposed to mentioning that in the manual as well, but I see no problem > > with what we have. > > I see. Sounds good to me. I meant enabling/disabling features when I say “adding/removing” features. Does that make anything different? Yes, that's how I understood what you were saying: changing the list of features enabled/disabled by specific levels. This is not a user-level thing, so describing it in the ELisp manual is good enough, I think. (If it turns out users want to do this kind of thing too often, it probably means our design of the user-facing features is sub-optimal and should be improved.)