From: Eli Zaretskii <eliz@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: mattias.engdegard@gmail.com, 61730@debbugs.gnu.org,
monnier@iro.umontreal.ca
Subject: bug#61730: 30.0.50; Compiler warnings for delq and delete
Date: Fri, 24 Feb 2023 17:48:03 +0200 [thread overview]
Message-ID: <83zg93m5e4.fsf@gnu.org> (raw)
In-Reply-To: <87bkljf4oh.fsf@web.de> (message from Michael Heerdegen on Fri, 24 Feb 2023 16:45:18 +0100)
> From: Michael Heerdegen <michael_heerdegen@web.de>
> Cc: mattias.engdegard@gmail.com, 61730@debbugs.gnu.org,
> monnier@iro.umontreal.ca
> Date: Fri, 24 Feb 2023 16:45:18 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Not in my opinion. I'm sick and tired from seeing compilers emitting
> > bogus warnings which require one to spend time verifying perfectly
> > correct code, or, worse, modify the code to shut up the compiler. Do
> > we really want to see stuff like
> >
> > (setq _ (delq ...))
> >
> > in our code?
>
> That's a bit of an exaggeration: the code would just look like in the
> thousands of other cases where we are not sure whether the element to
> delete is not at the head, like
>
> (setq my-list (delq elt my-list))
>
> which is not worse, even better readable IMO, than a naked `delq'
> call.
Even though my-list is never used again in the program? How is this
better than "(setq _ ..."?
> > If it's really impossible (and I'm not sure it is), then the better
> > course of action is to emit the warnings only if the byte compiler was
> > requested to be more sensitive to potential issues, similar to GCC's
> > "-W*" options. IOW, if someone wants to lint their code, let them ask
> > for a linting compilation.
>
> But I would be okay with that.
Great, thanks.
next prev parent reply other threads:[~2023-02-24 15:48 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 10:29 bug#61730: 30.0.50; Compiler warnings for delq and delete Michael Heerdegen
2023-02-24 3:59 ` Richard Stallman
2023-02-24 13:43 ` Mattias Engdegård
2023-02-24 13:56 ` Eli Zaretskii
2023-02-24 15:11 ` Michael Heerdegen
2023-02-24 15:29 ` Eli Zaretskii
2023-02-24 15:45 ` Michael Heerdegen
2023-02-24 15:48 ` Eli Zaretskii [this message]
2023-02-24 16:17 ` Michael Heerdegen
2023-02-24 16:45 ` Michael Heerdegen
2023-02-24 19:33 ` Mattias Engdegård
2023-02-24 20:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-25 9:40 ` Mattias Engdegård
2023-02-25 4:15 ` Richard Stallman
2023-02-25 8:11 ` Eli Zaretskii
2023-02-25 12:34 ` Michael Heerdegen
2023-02-25 13:25 ` Eli Zaretskii
2023-02-25 15:09 ` Michael Heerdegen
2023-02-25 15:29 ` Michael Heerdegen
2023-02-25 15:48 ` Eli Zaretskii
2023-02-27 3:22 ` Richard Stallman
2023-02-27 10:37 ` Michael Heerdegen
2023-02-27 11:37 ` Eli Zaretskii
2023-02-27 3:24 ` Richard Stallman
2023-02-27 11:44 ` Eli Zaretskii
2023-02-24 15:52 ` Mattias Engdegård
2023-02-24 16:37 ` Michael Heerdegen
2023-04-09 16:41 ` Mattias Engdegård
2023-05-01 16:06 ` Mattias Engdegård
2023-05-20 1:57 ` Michael Heerdegen
2023-05-20 9:14 ` Mattias Engdegård
2023-05-21 0:56 ` Michael Heerdegen
2023-05-21 3:01 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-21 3:57 ` Michael Heerdegen
2023-05-21 5:55 ` Eli Zaretskii
2023-05-21 8:42 ` Mattias Engdegård
2023-05-31 14:38 ` Mattias Engdegård
2023-06-01 0:48 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zg93m5e4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61730@debbugs.gnu.org \
--cc=mattias.engdegard@gmail.com \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).