From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62823: 29.0.60; Fixing a small leak in tree-sitter search functions Date: Fri, 14 Apr 2023 09:45:47 +0300 Message-ID: <83zg7bezc4.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11517"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62823@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 14 08:47:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnDDF-0002jZ-1f for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Apr 2023 08:47:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnDD6-000771-Mn; Fri, 14 Apr 2023 02:47:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnDD5-00076b-1r for bug-gnu-emacs@gnu.org; Fri, 14 Apr 2023 02:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pnDD4-0003D1-LO for bug-gnu-emacs@gnu.org; Fri, 14 Apr 2023 02:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pnDD4-0002iy-Fr for bug-gnu-emacs@gnu.org; Fri, 14 Apr 2023 02:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Apr 2023 06:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62823 X-GNU-PR-Package: emacs Original-Received: via spool by 62823-submit@debbugs.gnu.org id=B62823.168145477010386 (code B ref 62823); Fri, 14 Apr 2023 06:47:02 +0000 Original-Received: (at 62823) by debbugs.gnu.org; 14 Apr 2023 06:46:10 +0000 Original-Received: from localhost ([127.0.0.1]:45302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnDCE-0002hS-Dy for submit@debbugs.gnu.org; Fri, 14 Apr 2023 02:46:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnDCD-0002hG-8N for 62823@debbugs.gnu.org; Fri, 14 Apr 2023 02:46:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnDC6-00036M-Gu; Fri, 14 Apr 2023 02:46:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RevooRCZxfqs8YKQMrGIu1+vtjXZKUgAwkMbPCJMu2k=; b=DBuVlBS73fzh aKYNFxEuNREMWb6nfWd8wXhaAEfZ9Th8mFhw2yhpX+BxOKpiyBqK/fdyEwZvVRnYXTqzKePNhnCB6 Q/eu9UM/GyJXE1nFRjX2SASx8uBdUVGhGngZoRHxlsFS5/zGsQMZq6Um83HAVkSxHbtXrEX2Hf0GF Q4n2pcTy4uOInIjw99szcFY4EPU9bg8wT8X1nWvjgOha7wX/sUzSz8Y+EybaTpD8w2OgVx1FfjcbU /+V4fdcyDnxVz+y4AMsaXXbKOs/WMhlTW+LseMXAwi9PJhWceBC8qTV8uFnt+D2GJu+WfKGMdqWJL MJXxQIPYXMYk8pfsNkM9dw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnDBv-0007gl-RW; Fri, 14 Apr 2023 02:46:00 -0400 In-Reply-To: (message from Yuan Fu on Thu, 13 Apr 2023 15:48:43 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259893 Archived-At: > From: Yuan Fu > Date: Thu, 13 Apr 2023 15:48:43 -0700 > > When we switch to using cursors instead of nodes [1] in treesit.c for > search functions, we introduced a small leak: the search functions > allows the user to pass a predicate function, which can signal. And > because we are now using cursors, which needs to be freed, everytime the > predicate function signals, the cursor is leaked. > > I pushed a fix to master (a5eb9f6ad4e), the change is relatively > straightforward so I hope we can pick it into the next pretest. Thanks, but this kind of bugs should be fixed on the release branch to begin with (I've backported it now). If you are unsure on which branch to install such changes, please ask before installing.