From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62858: 30.0.50; Typo in gdb-mi.el Date: Tue, 18 Apr 2023 14:37:40 +0300 Message-ID: <83zg758lq3.fsf@gnu.org> References: <87ttxhs2x0.fsf@ledu-giraud.fr> <838retcjvs.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6525"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62858@debbugs.gnu.org, manuel@ledu-giraud.fr To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 18 13:38:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pojfJ-0001W5-Qb for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Apr 2023 13:38:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pojez-0003q0-OR; Tue, 18 Apr 2023 07:38:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pojew-0003oA-8y for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 07:38:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pojes-0001UN-5C for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 07:38:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pojes-0006VE-0Z for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 07:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Apr 2023 11:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62858 X-GNU-PR-Package: emacs Original-Received: via spool by 62858-submit@debbugs.gnu.org id=B62858.168181786424973 (code B ref 62858); Tue, 18 Apr 2023 11:38:01 +0000 Original-Received: (at 62858) by debbugs.gnu.org; 18 Apr 2023 11:37:44 +0000 Original-Received: from localhost ([127.0.0.1]:58005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pojea-0006Ui-2i for submit@debbugs.gnu.org; Tue, 18 Apr 2023 07:37:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pojeW-0006UT-4g for 62858@debbugs.gnu.org; Tue, 18 Apr 2023 07:37:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pojeQ-0001PV-4P; Tue, 18 Apr 2023 07:37:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=In2VQ73fmqujaz4rq//GgtcEHdNWnOZ/53tmdhJDZrg=; b=YyhtYM6mTQg8 W/j+hu2yaZOUwq4sHYpxkYKclzOWGCCBHNW3G91/lD+jvFa8URmTqoS2nLvl1CV5/YfWQ/6s2BUqW SBdXmRl6noFxeun/fXk/DD/kQIhm5Oecl7Kb77jgUJIlXUV7JeVMMARg3yvTg0h1jr19Ou24BqD+y p36m7MepT48gIJkWSC+lqnxa9o3jU3fp/85TdbCGyk9yaO2Hv6o6er9rhBiLjUcCMBv+SuMPFXe90 PTvNT+B3+h/LCCbQPadqBGEXMsn2pGaCW6Wch/GBbpJ9sUSXP9b8nI1OWXuGw4IoOpZ+8D9uNUKDN hWkJGiX9ZqrAbONBkSWg7g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pojeP-0002yJ-EK; Tue, 18 Apr 2023 07:37:33 -0400 In-Reply-To: <838retcjvs.fsf@gnu.org> (message from Eli Zaretskii on Sat, 15 Apr 2023 17:14:47 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260216 Archived-At: > Cc: 62858@debbugs.gnu.org > Date: Sat, 15 Apr 2023 17:14:47 +0300 > From: Eli Zaretskii > > > Date: Sat, 15 Apr 2023 15:14:35 +0200 > > From: Manuel Giraud via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > I do not think that it generates a bug but while browsing "gdb-mi.el", I > > noticed the following at line 2409: > > --8<---------------cut here---------------start------------->8--- > > ("=" . (("thread-created" . (gdb-thread-created . atomic)) > > ("thread-selected" . (gdb-thread-selected . atomic)) > > ("thread-existed" . (gdb-ignored-notification . atomic)) > > --8<---------------cut here---------------end--------------->8--- > > > > Should it not be "thread-exited"? There is no reference to > > "thread-existed" in the GDB info. > > You are right. But I think the snafu here is even more than just a > typo. This code was introduced in commit 6ff2c8f1f, where Stefan > (CC'ed) took a patch by Jean-Philippe Gravel and improved it. But as > part of that change, Stefan made this typo, and also made > gdb-thread-exited a function that no one calls, which was not what > happened with the original code. > > So I think we need to fix that with the patch below. > > Stefan, any comments? No more comments, so I've now installed the patch on the emacs-29 branch, and I'm therefore closing this bug.