From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60418: [PATCH] Add :vc keyword to use-package Date: Fri, 05 May 2023 09:53:45 +0300 Message-ID: <83zg6ji806.fsf@gnu.org> References: <87zgb6uk2r.fsf@hyperspace> <87cz4ezpwi.fsf@betli.tmit.bme.hu> <87h6tlinft.fsf@hyperspace> <87r0spa712.fsf@posteo.net> <87edopiif5.fsf@hyperspace> <87wn2bzvcp.fsf@hyperspace> <835y9vbyfr.fsf@gnu.org> <87mt36uwl8.fsf@hyperspace> <83ttxd8k1z.fsf@gnu.org> <87v8hrn56l.fsf@hyperspace> <87cz3w2lvb.fsf@posteo.net> <87jzy3ku6u.fsf@hyperspace> <87bkje93ou.fsf@posteo.net> <87y1mhihhy.fsf@hyperspace> <87ildbet2d.fsf@hyperspace> <831qjyoqj5.fsf@gnu.org> <87h6suolt2.fsf@hyperspace> <83ttwun4q4.fsf@gnu.org> <87o7n0fr9e.fsf@hyperspace> <878re3cqro.fsf@posteo.net> <83ild7jq5c.fsf@gnu.org> <87v8h7ba55.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4726"; mail-complaints-to="usenet@ciao.gmane.io" Cc: soliditsallgood@mailbox.org, felician.nemeth@gmail.com, 60418@debbugs.gnu.org, stefankangas@gmail.com To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 05 08:54:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pupKt-0000tt-LO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 May 2023 08:54:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pupKo-00087o-F2; Fri, 05 May 2023 02:54:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pupKO-0007zs-OU for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 02:54:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pupKO-0004IJ-G8 for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 02:54:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pupKO-0000NM-BW for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 02:54:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 May 2023 06:54:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60418-submit@debbugs.gnu.org id=B60418.16832695831247 (code B ref 60418); Fri, 05 May 2023 06:54:04 +0000 Original-Received: (at 60418) by debbugs.gnu.org; 5 May 2023 06:53:03 +0000 Original-Received: from localhost ([127.0.0.1]:53025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pupJO-0000K3-Ng for submit@debbugs.gnu.org; Fri, 05 May 2023 02:53:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pupJM-0000JL-Ap for 60418@debbugs.gnu.org; Fri, 05 May 2023 02:53:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pupJF-0003gv-VI; Fri, 05 May 2023 02:52:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=OlFMdX3us3dqH0hU4D4sQQglMiQIUqyrZL0wXQmb2NE=; b=m71XxfMvK7p6yLDzKDrF pjhBgvCx7CiwzmMQhHwIg0HPt/SgS+CS/IuyAC0l84OwKLNFtHlMrIUuc/x65+hKLkCmLv9GGNriW CgTymxYEWbSLuu66NJPx/JCUp2s20qjHOB0rU2Jst76wbgMUEffDHxrxxUj4pkhWazmfxt0wikzNK 1VvOLqDtu+eaJpsaWEnjvqg3exfsmGD66nz+6M44aYWW1NoiL2hdnFVTjswrKTCyE6GfATdpSZAvv kM34R8VwJWeZnu4VCfv2mzg2f8mq871wXlZOUuj3qAz6wmNNiRkULjlxZwR9u2N6F+ZbRq8Vf4BgI CypKrftcfU827Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pupJF-0001Uj-DB; Fri, 05 May 2023 02:52:53 -0400 In-Reply-To: <87v8h7ba55.fsf@posteo.net> (message from Philip Kaludercic on Fri, 05 May 2023 05:49:26 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261072 Archived-At: > From: Philip Kaludercic > Cc: soliditsallgood@mailbox.org, 60418@debbugs.gnu.org, > felician.nemeth@gmail.com, stefankangas@gmail.com > Date: Fri, 05 May 2023 05:49:26 +0000 > > >> How about we just say "the commit of the latest release"? > > > > When package-vc-install is used, what is "the latest release"? isn't > > that the HEAD of the default branch? IOW, what about packages that > > make no releases at all? > > No, the commit of the latest release is interpreted the same way as > elpa-admin.el does, namely the last revision that modified the "Version" > header. If no such commit can be found, then a message is printed out > and the installation continues under the assumption that the package is > using a rolling-release model. I thought package-vc-install is used (or at least can be used) to fetch the latest HEAD from the upstream repository? I even thought this was its main raison d'être? If that's not true, does it mean we have no means for package users to track the latest development code of a package? > >> Are there any other places where we can fix this confusion? > > > > I guess the documentation of package-vc-install shares these issues? > > How does this sound like to you: > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index 8f62e7d65f3..b28e33b3b89 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -747,11 +747,14 @@ package-vc-install > symbol whose name is the package name, and the URL for the > package will be taken from the package's metadata. > > -By default, this function installs the last version of the package > -available from its repository, but if REV is given and non-nil, it > -specifies the revision to install. If REV has the special value > -`:last-release' (interactively, the prefix argument), that stands > -for the last released version of the package. > +By default, this function installs the last revision of the > +package available from its repository, but if REV is given and > +non-nil, it specifies the revision to install. If REV has the > +special value `:last-release' (interactively, the prefix > +argument), an attempt is made to find the revision of the latest > +release. This is done by looking up the last revision that > +modified the \"Version\" header, as described in the Info > +node `(elisp) Library Headers'. First, too much of passive voice. More importantly, this still doesn't tell: . what is "the last revision", the one installed if REV is omitted? . what are possible values of REV, in addition to :last-release, and how are those values interpreted, in VCS terms? > I can apply this or any variation thereof to emacs-29. emacs-29 is fine for documentation changes.