From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63481: 29.0.90; src/treesit-tests fail in treesit-basic-parsing Date: Thu, 18 May 2023 14:23:01 +0300 Message-ID: <83zg61vq7e.fsf@gnu.org> References: <835y8wbuoz.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9463"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63481@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 18 13:23:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzbj8-0002Gy-VX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 May 2023 13:23:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzbis-0002JN-2Q; Thu, 18 May 2023 07:23:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzbio-0002Ij-Gg for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 07:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzbio-0008JL-28 for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 07:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzbin-0007Qj-TM for bug-gnu-emacs@gnu.org; Thu, 18 May 2023 07:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 May 2023 11:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63481 X-GNU-PR-Package: emacs Original-Received: via spool by 63481-submit@debbugs.gnu.org id=B63481.168440897628536 (code B ref 63481); Thu, 18 May 2023 11:23:01 +0000 Original-Received: (at 63481) by debbugs.gnu.org; 18 May 2023 11:22:56 +0000 Original-Received: from localhost ([127.0.0.1]:52219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzbih-0007QB-F2 for submit@debbugs.gnu.org; Thu, 18 May 2023 07:22:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzbig-0007Pz-5w for 63481@debbugs.gnu.org; Thu, 18 May 2023 07:22:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzbia-0008Fn-Vf; Thu, 18 May 2023 07:22:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VbvwaTZyN9DchVFZj3RFyzWnIDHo9mK40Enfqm8To4U=; b=BiLTQVRE4kPb OkVkNAkJ7TwX09wZCsT7iAAB80AnTuaHqhVLVb7nPJuFMqfxmcoLAxWWHUPjxAAhEcBj29VucgGvW E/9W0Mrq/RI9r6jUu9zwfbQGdfxgUGYx36aFIugnUiRoGZyIvx1aIMy6bs6CWdf5yhdsF3/mMBWh1 cySCdfIfPu1NEI6bQg3S+2fXqNNNS+vHpy+ZQUn523WsEzHBHnshMR5smiPMGCdrfyNeqsLwBXA6I z5nuOrKjDqkjjyf1H35mGrN6dsNUpDCJcwAEmDMVIEphf0YAfIxgU7GAbvpt4jWikqvUEj81qnIx4 VaNb+7duYx0Ckat3q+/MRA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzbia-0006rm-Fe; Thu, 18 May 2023 07:22:48 -0400 In-Reply-To: <835y8wbuoz.fsf@gnu.org> (message from Eli Zaretskii on Sat, 13 May 2023 09:40:28 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261922 Archived-At: Ping! > Date: Sat, 13 May 2023 09:40:28 +0300 > From: Eli Zaretskii > > To reproduce: > > $ cd test > $ make src/treesit-tests SELECTOR='treesit-basic-parsing' > > This results in: > > GEN src/treesit-tests.log > make[1]: Entering directory `/d/gnu/git/emacs/branch/test' > Running 1 tests (2023-05-13 09:36:51+0300, selector `treesit-basic-parsing') > Test treesit-basic-parsing backtrace: > signal(ert-test-failed (((should (equal (treesit-node-string (treesi > ert-fail(((should (equal (treesit-node-string (treesit-parser-root-n > (if (unwind-protect (setq value-12 (apply fn-10 args-11)) (setq form > (let (form-description-14) (if (unwind-protect (setq value-12 (apply > (let ((value-12 'ert-form-evaluation-aborted-13)) (let (form-descrip > (let* ((fn-10 #'equal) (args-11 (condition-case err (let ((signal-ho > (let ((parser (treesit-parser-create 'json))) (let* ((fn-5 #'eq) (ar > (progn (let ((parser (treesit-parser-create 'json))) (let* ((fn-5 #' > (unwind-protect (progn (let ((parser (treesit-parser-create 'json))) > (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn > (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current > (closure (t) nil (let* ((fn-0 #'treesit-language-available-p) (args- > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name treesit-basic-parsing :documentation > ert-run-or-rerun-test(#s(ert--stats :selector treesit-basic-parsing > ert-run-tests(treesit-basic-parsing #f(compiled-function (event-type > ert-run-tests-batch(treesit-basic-parsing) > ert-run-tests-batch-and-exit(treesit-basic-parsing) > eval((ert-run-tests-batch-and-exit 'treesit-basic-parsing) t) > command-line-1(("-L" ";." "-l" "ert" "-l" "src/treesit-tests.el" "-- > command-line() > normal-top-level() > Test treesit-basic-parsing condition: > (ert-test-failed > ((should > (equal > (treesit-node-string ...) > "(ERROR)")) > :form > (equal "(document)" "(ERROR)") > :value nil :explanation > (arrays-of-different-length 10 7 "(document)" "(ERROR)" first-mismatch-at 1))) > FAILED 1/1 treesit-basic-parsing (0.000000 sec) at src/treesit-tests.el:59 > > Ran 1 tests, 0 results as expected, 1 unexpected (2023-05-13 09:36:52+0300, 1.078125 sec) > > It looks to me that the test assumes an empty buffer should parse as > an error, but the latest JSON grammar succeeds to parse it as a valid > document. > > The rest of treesit-tests pass as expected. > > Can this be fixed, please? > > > In GNU Emacs 29.0.90 (build 93, i686-pc-mingw32) of 2023-05-13 built on > HOME-C4E4A596F7 > Repository revision: 4bda96273490e025d1fd1a50b4bf3cab1b2def1c > Repository branch: emacs-29 > Windowing system distributor 'Microsoft Corp.', version 5.1.2600 > System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600) > > Configured using: > 'configure -C --prefix=/d/usr --with-wide-int > --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3'' > > Configured features: > ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY > W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF > TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB > > Important settings: > value of $LANG: ENU > locale-coding-system: cp1255 > > Major mode: Lisp Interaction > > Minor modes in effect: > tooltip-mode: t > global-eldoc-mode: t > eldoc-mode: t > show-paren-mode: t > electric-indent-mode: t > mouse-wheel-mode: t > tool-bar-mode: t > menu-bar-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > blink-cursor-mode: t > line-number-mode: t > indent-tabs-mode: t > transient-mark-mode: t > auto-composition-mode: t > auto-encryption-mode: t > auto-compression-mode: t > > Load-path shadows: > None found. > > Features: > (shadow sort mail-extr emacsbug message mailcap yank-media puny dired > dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 > epg-config gnus-util text-property-search time-date subr-x mm-decode > mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader > cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util > mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric > uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32 > ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win > tool-bar dnd fontset image regexp-opt fringe tabulated-list replace > newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar > rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock > font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq > simple cl-generic indonesian philippine cham georgian utf-8-lang > misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms > cp51932 hebrew greek romanian slovak czech european ethiopic indian > cyrillic chinese composite emoji-zwj charscript charprop case-table > epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button > loaddefs theme-loaddefs faces cus-face macroexp files window > text-properties overlay sha1 md5 base64 format env code-pages mule > custom widget keymap hashtable-print-readable backquote threads > w32notify w32 lcms2 multi-tty make-network-process emacs) > > Memory information: > ((conses 16 42737 8492) > (symbols 48 6286 0) > (strings 16 16561 1835) > (string-bytes 1 399112) > (vectors 16 9323) > (vector-slots 8 147333 11986) > (floats 8 23 33) > (intervals 40 273 71) > (buffers 888 10)) > > > >