From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63625: 29.0.90; package-install inserts package directory into load-path twice. Date: Mon, 22 May 2023 14:25:02 +0300 Message-ID: <83zg5wpq0h.fsf@gnu.org> References: <4ACD9E26-B5A6-412E-8DFC-C09C05A4EACD@mac.com> <871qj8lp8u.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12235"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63625@debbugs.gnu.org, toddasmith@mac.com To: Robert Pluim , Philip Kaludercic , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 22 13:25:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q13f1-0002y8-Sy for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 May 2023 13:25:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q13ey-0006gW-Jt; Mon, 22 May 2023 07:25:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q13ex-0006gO-4F for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 07:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q13ew-0001lV-QJ for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 07:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q13ew-0002rp-9z for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 07:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 May 2023 11:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63625 X-GNU-PR-Package: emacs Original-Received: via spool by 63625-submit@debbugs.gnu.org id=B63625.168475468810999 (code B ref 63625); Mon, 22 May 2023 11:25:02 +0000 Original-Received: (at 63625) by debbugs.gnu.org; 22 May 2023 11:24:48 +0000 Original-Received: from localhost ([127.0.0.1]:33704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q13ei-0002rI-Bt for submit@debbugs.gnu.org; Mon, 22 May 2023 07:24:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q13eg-0002r4-FU for 63625@debbugs.gnu.org; Mon, 22 May 2023 07:24:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q13eb-0001iF-4w; Mon, 22 May 2023 07:24:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=n7NfqjDrS+YVy5Uqa1TZmpOat8XGqAGflu0/1GwwOVA=; b=c2ZAhAUvRDLs31543Kmi 3/siOCesqFejj9lU1UjpuH3m2DKbbC4a2OlDsg+7USTXjC+AHF0D6zih2Z4N/QjWd6Iz83Wl3GyWi dTVxtPEknFBqQ7GSEkk05iQJ39Tn7j9T7Hp+JDRUJ+zo/k1YI6H2VOBRLH9UFpx09ERgtbF+wNd56 e77W79mZITJ4MqsPz7gxkMPurJIAWf4iJYuwuIPd0NjNJxzGn5wxvFP1fxsuY2UoYQ/xOmr6JY910 Ezx7N7XvGEVRsUwOBfCWwYHDt6I0hB7BZMVGqS9evAffDV+wJBxMXkzeiHbjAPXHXXpZuZucOOJJW /E7P79uVv4/loA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q13ea-0003HW-37; Mon, 22 May 2023 07:24:40 -0400 In-Reply-To: <871qj8lp8u.fsf@gmail.com> (message from Robert Pluim on Mon, 22 May 2023 10:55:13 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262144 Archived-At: > Cc: todd smith > From: Robert Pluim > Date: Mon, 22 May 2023 10:55:13 +0200 > > This is because we didnʼt respect DRY. package.el should use the > package support of `loaddefs-generate', but that doesnʼt expose the > requisite feature of `loaddefs-generate--rubric' (maybe on master it does). > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index 78017b77677..31e5e0809a8 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -1107,8 +1107,9 @@ package-generate-autoloads > ;; Add the directory that will contain the autoload file to > ;; the load path. We don't hard-code `pkg-dir', to avoid > ;; issues if the package directory is moved around. > + (directory-file-name > (or (and load-file-name (file-name-directory load-file-name)) > - (car load-path))))) > + (car load-path)))))) > (let ((buf (find-buffer-visiting output-file))) > (when buf (kill-buffer buf))) > auto-name)) Thanks. Philip, Stefan: any comments or suggestions?