From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Fri, 21 Jul 2023 18:55:54 +0300 Message-ID: <83zg3p9s39.fsf@gnu.org> References: <87tttypp2e.fsf@localhost> <837cqu35lw.fsf@gnu.org> <87o7k6pmk3.fsf@localhost> <834jly351p.fsf@gnu.org> <87lefapkdx.fsf@localhost> <831qh230h5.fsf@gnu.org> <87wmyu8mi0.fsf@localhost> <83wmyu1l1k.fsf@gnu.org> <87fs5hemi1.fsf@gmx.de> <83edl11qzn.fsf@gnu.org> <874jlxebz5.fsf@gmx.de> <87lef9mqio.fsf@localhost> <87edl1scbw.fsf@gmx.de> <87fs5hmp6i.fsf@localhost> <87cz0lmoxy.fsf@localhost> <83v8edzb31.fsf@gnu.org> <87r0p1cta3.fsf@gmx.de> <87pm4ll7ox.fsf@localhost> <87a5vpcmc7.fsf@gmx.de> <878rb9l1f5.fsf@localhost> <87zg3pb6yt.fsf@gmx.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30197"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, yantar92@posteo.net, 64735@debbugs.gnu.org, sbaugh@janestreet.com To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 21 17:56:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMsUd-0007dc-I4 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jul 2023 17:56:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMsU7-00052L-6U; Fri, 21 Jul 2023 11:56:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMsU6-000527-5z for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 11:56:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMsU5-0003iB-Qs for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 11:56:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMsU5-000608-MY for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 11:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jul 2023 15:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.168995493923018 (code B ref 64735); Fri, 21 Jul 2023 15:56:01 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 21 Jul 2023 15:55:39 +0000 Original-Received: from localhost ([127.0.0.1]:34597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMsTi-0005zC-MM for submit@debbugs.gnu.org; Fri, 21 Jul 2023 11:55:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMsTg-0005yy-3g for 64735@debbugs.gnu.org; Fri, 21 Jul 2023 11:55:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMsTQ-0003RM-3z; Fri, 21 Jul 2023 11:55:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ttl1E6ptYzqju6Jetua3CqswqmmOTyheJ1HRao74IT8=; b=F1jOrrqkw4i7 dZr2tHQ6SBjl+hewiPuasfLSoAFOs0zzybPRLDkaIFkSbP07ps+iRV8wlow5Stk4IRcsDSX3hkvuM dbYsSoaE4Irul5skTwBxspZlvt3P+HakrhKYSSv/yXSHpdqAuT66d1S/iwtdg7R/k/DxGph38s6gv dVVQpuJ++bEvw/Pk4PcWGwc1eBLxMUrA7YfT4fb5HeTzh4fwU0aDpgPko0JN4860TXaDqSN5LnSyb Msf9sePSN2qjQHGAiNOgn1Gnmzx8iffqd4UbeXxoyV0vkakiknwi4V7IBJrW7z4AoyRZiijZo8AHC vz4CDwoG0/xCyvDbaNsf1Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMsTO-0000WQ-1H; Fri, 21 Jul 2023 11:55:18 -0400 In-Reply-To: <87zg3pb6yt.fsf@gmx.de> (message from Michael Albinus on Fri, 21 Jul 2023 17:49:14 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265737 Archived-At: > From: Michael Albinus > Cc: Eli Zaretskii , dmitry@gutov.dev, 64735@debbugs.gnu.org, > sbaugh@janestreet.com > Date: Fri, 21 Jul 2023 17:49:14 +0200 > > Ihor Radchenko writes: > > Hi Ihor, > > >> My point was to show the differences in the approaches. Do you have also > >> numbers using without-remote-files and inhibit-remote-files? > > > > (length (directory-files-recursively "~/Git" "")) > > ;; => 113628 > > (benchmark-run-compiled 1 (directory-files-recursively "~/Git" "")) > > ;; => (1.597328425 1 0.47237324699997885) > > (benchmark-run-compiled 1 (let (file-name-handler-alist) (directory-files-recursively "~/Git" ""))) > > ;; => (1.0012111910000001 1 0.4860752540000135) > > (benchmark-run-compiled 1 (without-remote-files (directory-files-recursively "~/Git" ""))) > > ;; => (1.147276594 1 0.48820330999998873) > > (inhibit-remote-files) > > (benchmark-run-compiled 1 (directory-files-recursively "~/Git" "")) > > ;; => (1.054041615 1 0.4141427399999884) > > Thanks a lot! These figures show, that both without-remote-files and > inhibit-remote-files are useful. Of course this shouldn't stop us to > find further approaches for performance optimizations. > > I'll wait for some days whether there's opposition, before installing > them in master. Can you spell out what you intend to install? The figures provided in this thread indicate speedups that are modest at best, so I'm not sure they justify measures which could cause problems (if that indeed could happen).