From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61394: 30.0.50; [PATCH] Image-dired thumb name based on content Date: Fri, 04 Aug 2023 13:55:22 +0300 Message-ID: <83zg37ulet.fsf@gnu.org> References: <874jruy7xx.fsf@ledu-giraud.fr> <871qgumqh7.fsf@ledu-giraud.fr> <83ila5n8co.fsf@gnu.org> <87fs59qx54.fsf@ledu-giraud.fr> <83wmyll9s5.fsf@gnu.org> <87bkfxcaa2.fsf@ledu-giraud.fr> <83wmykjzji.fsf@gnu.org> <877cqkcrds.fsf@ledu-giraud.fr> <83bkfwjkh8.fsf@gnu.org> <871qgsc9fv.fsf@ledu-giraud.fr> <83y1izj2q6.fsf@gnu.org> <87leezhwq0.fsf@ledu-giraud.fr> <87edko9ixu.fsf@ledu-giraud.fr> <87h6piu1zj.fsf@ledu-giraud.fr> <83wmydzn4z.fsf@gnu.org> <87sf91jpe4.fsf@ledu-giraud.fr> <83a5v9z4ve.fsf@gnu.org> <87o7jojs98.fsf@ledu-giraud.fr> <833510xsnt.fsf@gnu.org> <87jzucjchb.fsf@ledu-giraud.fr> <83sf90vv06.fsf@gnu.org> <87bkfnjlp2.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20388"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, stefankangas@gmail.com, 61394@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 04 12:56:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRsTg-00058I-Sy for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Aug 2023 12:56:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRsTT-0008O2-H0; Fri, 04 Aug 2023 06:56:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRsTS-0008Nu-EF for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 06:56:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRsTS-0002I3-5n for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 06:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRsTR-0006DN-Pg for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 06:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 10:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61394 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61394-submit@debbugs.gnu.org id=B61394.169114652223840 (code B ref 61394); Fri, 04 Aug 2023 10:56:01 +0000 Original-Received: (at 61394) by debbugs.gnu.org; 4 Aug 2023 10:55:22 +0000 Original-Received: from localhost ([127.0.0.1]:53480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRsSo-0006CS-4w for submit@debbugs.gnu.org; Fri, 04 Aug 2023 06:55:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRsSj-0006C9-7h for 61394@debbugs.gnu.org; Fri, 04 Aug 2023 06:55:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRsSd-0001bC-Fz; Fri, 04 Aug 2023 06:55:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6DtWohh2QJH/ewi0HvjSOOeQt9XXL39/7DL4KVBPSAo=; b=g62jo/BMknEZ 6g/cka78aES6R4NAzEKI28a7vbPlJEUSRrTj7gYeXaZpIa8f1ugjpiyBkl5BWzLhPGbkT7QVt8O9q wvTCG1q0nKuIwmdc/qXAkNPsZ70QMd7q13QVV7JgFPtnloDDGFzRU7IXCytmynBUBlckbmfYO5dr4 M6XuSjpBtwoC4eKSlm6qsymPZGY4H83LbeTR9qibj+34FE3etK3CXzs6vwPM/FhLmFujf8NCbGfWU Xi0/ky5PDu91MyoOB9bUSn5nCjwbQUjUfwTBItTL90/UJFFfC1pfYIt70NDRIXyvoWXtrfN+r/Weg OpaBjc/SGaMTktdqa4rvuA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRsSc-0008Om-VU; Fri, 04 Aug 2023 06:55:11 -0400 In-Reply-To: <87bkfnjlp2.fsf@ledu-giraud.fr> (message from Manuel Giraud on Fri, 04 Aug 2023 09:44:41 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266662 Archived-At: > From: Manuel Giraud > Cc: stefankangas@gmail.com, contovob@tcd.ie, 61394@debbugs.gnu.org > Date: Fri, 04 Aug 2023 09:44:41 +0200 > > > What I had in mind is this: > > > > (defun image-dired-update-thumbnail-at-point () > > "Update the thumbnail at point if the original image file has been modified. > > This function uncaches and removes the thumbnail file under the old name." > > > > OK? > > Ok. Sorry I misread your reply ("move" not "remove"). BTW, I'm using > 'M-q' on docstring and my fill-column is set to 70 (the default I > guess): is there a better way? 70 is okay as the default value, but when you cannot squeeze the first line into 70 columns, it is okay to use up to 79. > >> What about: > >> > >> "When 'image-dired-thumb-naming' is set to 'sha1-contents', 'thumb' and > >> 'old-thumb' could be different file names. Update the thumbnail then." > > > > Much better, thanks. > > Ok, so here is a new patch. Thanks, installed. Should this bug now be closed, or is there something else to do here?