From: Eli Zaretskii <eliz@gnu.org>
To: Paul Pogonyshev <pogonyshev@gmail.com>
Cc: dmitry@gutov.dev, 65763@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#65763: Error opening a file from a Git working directory if Git is not installed
Date: Sun, 10 Sep 2023 20:52:27 +0300 [thread overview]
Message-ID: <83zg1trk4k.fsf@gnu.org> (raw)
In-Reply-To: <CAG7Bpap+XcXwkLoxk1b2tjvGwQkpj+Gxn6trPfSMipkBQRVPMQ@mail.gmail.com> (message from Paul Pogonyshev on Sun, 10 Sep 2023 19:36:47 +0200)
> From: Paul Pogonyshev <pogonyshev@gmail.com>
> Date: Sun, 10 Sep 2023 19:36:47 +0200
> Cc: Dmitry Gutov <dmitry@gutov.dev>, monnier@iro.umontreal.ca, 65763@debbugs.gnu.org
>
> - ((setq backend (with-demoted-errors "VC refresh error: %S"
> - (vc-backend buffer-file-name)))
> + ((setq backend (let (debug-on-error)
> + (with-demoted-errors "VC refresh error: %S"
> + (vc-backend buffer-file-name))))
>
> From my experience, you should always comment such things. Or add an automated test ensuring it.
> Or even better, do both. It is extremely non-obvious why this is needed at all and someone can easily
> undo your changes a few years later.
Yes, if this (or anything like it) goes in, we will comment it. We
just haven't yet decided whether this will be the solution.
next prev parent reply other threads:[~2023-09-10 17:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 18:54 bug#65763: Error opening a file from a Git working directory if Git is not installed Paul Pogonyshev
2023-09-05 19:44 ` Eli Zaretskii
2023-09-05 20:06 ` Paul Pogonyshev
2023-09-05 20:14 ` Paul Pogonyshev
2023-09-06 2:25 ` Eli Zaretskii
2023-09-06 7:29 ` Paul Pogonyshev
2023-09-06 12:13 ` Eli Zaretskii
2023-09-06 12:35 ` Dmitry Gutov
2023-09-06 12:49 ` Paul Pogonyshev
2023-09-06 12:52 ` Dmitry Gutov
2023-09-06 13:11 ` Paul Pogonyshev
2023-09-06 14:31 ` Dmitry Gutov
2023-09-06 15:46 ` Eli Zaretskii
2023-09-06 15:59 ` Dmitry Gutov
2023-09-10 6:26 ` Eli Zaretskii
2023-09-10 13:21 ` Dmitry Gutov
2023-09-10 13:40 ` Eli Zaretskii
2023-09-10 17:36 ` Paul Pogonyshev
2023-09-10 17:52 ` Eli Zaretskii [this message]
2023-09-06 13:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zg1trk4k.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65763@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=monnier@iro.umontreal.ca \
--cc=pogonyshev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).