From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66673: [PATCH] Fix treesit-install-language-grammar recipe addition Date: Sun, 22 Oct 2023 08:15:02 +0300 Message-ID: <83zg0bp7ah.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19563"; mail-complaints-to="usenet@ciao.gmane.io" Cc: noah.v.peart@gmail.com, 66673@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 22 07:15:58 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1quQog-0004vK-Ka for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Oct 2023 07:15:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1quQoL-0006O0-C6; Sun, 22 Oct 2023 01:15:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quQoJ-0006Nq-0Q for bug-gnu-emacs@gnu.org; Sun, 22 Oct 2023 01:15:35 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1quQoI-0008N3-No for bug-gnu-emacs@gnu.org; Sun, 22 Oct 2023 01:15:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1quQok-0000Qc-6X for bug-gnu-emacs@gnu.org; Sun, 22 Oct 2023 01:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Oct 2023 05:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66673 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66673-submit@debbugs.gnu.org id=B66673.16979517431609 (code B ref 66673); Sun, 22 Oct 2023 05:16:02 +0000 Original-Received: (at 66673) by debbugs.gnu.org; 22 Oct 2023 05:15:43 +0000 Original-Received: from localhost ([127.0.0.1]:45367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quQoR-0000Pt-4D for submit@debbugs.gnu.org; Sun, 22 Oct 2023 01:15:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quQoL-0000PZ-IF for 66673@debbugs.gnu.org; Sun, 22 Oct 2023 01:15:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quQno-00080u-1t; Sun, 22 Oct 2023 01:15:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XiftXF3XjIb+mGeSH40WVAVlf6uaYnNFuIOKYHn/Cbw=; b=M2eNifxBmu4v ZFPG9U1s6jYpYdMO8kxqsjzp1vgNBMGQfZcJHIXwp7NgvuuqDl5e9I1agOLGhOu82dan4/2LWhHx0 FioizoTRMKHa/oWLq6s4+Ute90U3lw/WNfZDe66CrekMYa9wZr4Jao0ttYqeWRADIaBt3XDzXvUZJ s+2Wfa+/XmGyKSoAPn7hVKYcfOlhTkDCpu8kThXkEj6PnRBccxmbnxB60+P44bcFwW5HzAghPhIjH Ira2xG/92NieaD1ZdS2tImeweAmt9mke+FxC8XvpPB4dkifcCLhl3vfoEqI8XyTgVs10tVr6wiGYD gATDAmhnG4x1GE6yeXvBDg==; In-Reply-To: (message from Yuan Fu on Sat, 21 Oct 2023 20:40:52 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272955 Archived-At: > Resent-To: bug-gnu-emacs@gnu.org > Cc: 66673-done@debbugs.gnu.org > From: Yuan Fu > Date: Sat, 21 Oct 2023 20:40:52 -0700 > > > > > On Oct 21, 2023, at 8:09 PM, nvp wrote: > > > > > > > > * lisp/treesit.el (treesit-install-language-grammar): fix recipe > > addition to `treesit-language-source-alist` > > > > Bug: `treesit-install-language-grammar` adds repeated language > > entry to `treesit-language-source-alist` causing circular list. > > Thank you! I applied the path on emacs-29. Thanks. Yuan, if we are fixing treesit-install-language-grammar, I think it lacks the "-ltree-sitter" command-line option for the link command. At least on MS-Windows, this is required, as the link command will fail if we don't supply that option: the linker _must_ scan the tree-sitter library when generating the shared library for the grammar.