From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66470: 29.1; Provide Urdu input method Date: Sat, 04 Nov 2023 11:27:13 +0200 Message-ID: <83zfzt50ni.fsf@gnu.org> References: <87pm1lm23l.fsf@zohomail.eu> <87lec9m12g.fsf@zohomail.eu> <837cnpshz2.fsf@gnu.org> <877cnp1ojf.fsf@zohomail.eu> <83zg0lqxtq.fsf@gnu.org> <8734yd1mfm.fsf@zohomail.eu> <83sf6dqt33.fsf@gnu.org> <87zg0bye19.fsf@zohomail.eu> <83leblbq9e.fsf@gnu.org> <87v8apqtff.fsf@zohomail.eu> <83bkc96hg6.fsf@gnu.org> <87h6m1j3ad.fsf@zohomail.eu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19210"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66470@debbugs.gnu.org To: Rahguzar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 04 10:27:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzCwJ-0004mL-FE for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Nov 2023 10:27:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzCwB-0008AG-94; Sat, 04 Nov 2023 05:27:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzCwA-0008A1-AY for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 05:27:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzCwA-0000Eo-24 for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 05:27:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzCwk-0000sv-2g for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 05:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Nov 2023 09:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66470 X-GNU-PR-Package: emacs Original-Received: via spool by 66470-submit@debbugs.gnu.org id=B66470.16990900813394 (code B ref 66470); Sat, 04 Nov 2023 09:28:02 +0000 Original-Received: (at 66470) by debbugs.gnu.org; 4 Nov 2023 09:28:01 +0000 Original-Received: from localhost ([127.0.0.1]:60963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzCwi-0000sg-Vi for submit@debbugs.gnu.org; Sat, 04 Nov 2023 05:28:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzCwg-0000sQ-2t for 66470@debbugs.gnu.org; Sat, 04 Nov 2023 05:27:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzCvz-0000EC-C8; Sat, 04 Nov 2023 05:27:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oFvtZ9Tz/3S7eY1saI3g/EcyS/p6sSHtaY1SGgnBLKo=; b=j+0+cZoKEvpG TcOdU6jOpaBgA1p7TNxf6m9K/4L9vd9Gv+W1Yj5+jr+cRTuTWrJ1cokAk3o2aMyuFfnRXp13ObPte ELejLGuuHKwk0c6lqsCtB36F/eBY1GhtwrFRceFkFUlWUuHCAGEz5qgdlGYgJiFAOMDEJrrl4gDTL 9gWUqsa7TUAjZxC6PfclkaIDFpE6zcsmkDTqhCA4SkL35AaPI82KRv3sTNTBu58LfF3Dvz30rAZmg IctzRCPMva4FZlxOIvv7jKIESiaKUDT6+bPunG6C/elaqC3GkezuOVMM3uAbklo6fjvwFayhgnLdt NwczL11WtaqDNcJvRYvlWw==; In-Reply-To: <87h6m1j3ad.fsf@zohomail.eu> (message from Rahguzar on Sat, 04 Nov 2023 09:50:04 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273764 Archived-At: > From: Rahguzar > Cc: 66470@debbugs.gnu.org > Date: Sat, 04 Nov 2023 09:50:04 +0100 > > >> ; (pakistan--define-quail-rules): helper function > >> ; (pakistan--make-setter): helper function > >> ; (pakistan--regenerate-translations): helper function > >> ; (pakistan--set-prefixes): helper function > >> ; (pakistan--set-numeral-translations): > > > > Why are there semi-colons here? > > > > I thought these internal helper functions should be omitted from the > generated changelog. If not I will correct this too. We only omit entire commit log messages, not selected portions of them. So in this case, these semi-colons should be removed. > > While compiling this, I get byte-compiler warnings: > > > > In pakistan--define-quail-rules: > > leim/quail/pakistan.el:199:41: Warning: reference to free variable `pakistan-urdu-prefixes' > > > > In pakistan--regenerate-translations: > > leim/quail/pakistan.el:215:33: Warning: reference to free variable `pakistan-urdu-translations' > > leim/quail/pakistan.el:217:4: Warning: reference to free variable `pakistan-urdu-diacritics-and-other-symbols' > > leim/quail/pakistan.el:218:33: Warning: reference to free variable `pakistan-urdu-poetic-symbols' > > leim/quail/pakistan.el:219:33: Warning: reference to free variable `pakistan-urdu-religious-symbols' > > leim/quail/pakistan.el:220:33: Warning: reference to free variable `pakistan-extra-balochi-translations' > > leim/quail/pakistan.el:221:33: Warning: reference to free variable `pakistan-extra-pashto-translations' > > leim/quail/pakistan.el:222:33: Warning: reference to free variable `pakistan-extra-saraiki-translations' > > leim/quail/pakistan.el:223:33: Warning: reference to free variable `pakistan-extra-sindhi-translations' > > The byte compiler warnings are harmless in that the code referencing > those variables is run only after the variable is defined. The > `urdu-custom` input method is generated based on these customs > variables. However what the setter of one custom variable should do > depends on the value of the others which makes initializing them a > little complicated. > > The only way I see of silencing the warnings is to use `defvar` to > define the variables, then define the setters which references these > variables. Is this preferable to the current state? Yes, definitely. We don't want warnings while building Emacs, even if they are harmless.