From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66988: 30.0.50; treesit-forward-sexp not working properly in js-ts-mode and tsx-ts-mode Date: Sat, 11 Nov 2023 09:35:56 +0200 Message-ID: <83zfzkwxlv.fsf@gnu.org> References: <9cf7d7d0-33a3-4c07-bd66-bc4c59bdfefb@gmail.com> <39b0057b-ac0c-8271-0fe2-f4deef7ae8d3@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17300"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66988@debbugs.gnu.org, theo@thornhill.no, loic.lemaitre@gmail.com To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 11 08:36:37 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1iXl-0004Kg-8Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Nov 2023 08:36:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1iXX-0006qj-KM; Sat, 11 Nov 2023 02:36:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1iXV-0006qV-T2 for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 02:36:21 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1iXV-0000qE-KJ for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 02:36:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r1iY9-000863-Mb for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 02:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2023 07:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66988 X-GNU-PR-Package: emacs Original-Received: via spool by 66988-submit@debbugs.gnu.org id=B66988.169968822031117 (code B ref 66988); Sat, 11 Nov 2023 07:37:01 +0000 Original-Received: (at 66988) by debbugs.gnu.org; 11 Nov 2023 07:37:00 +0000 Original-Received: from localhost ([127.0.0.1]:51420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1iY8-00085o-Ab for submit@debbugs.gnu.org; Sat, 11 Nov 2023 02:37:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1iY5-00085U-ND for 66988@debbugs.gnu.org; Sat, 11 Nov 2023 02:36:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1iXL-0000LB-Q6; Sat, 11 Nov 2023 02:36:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=W3gkhA1awnhkoNttAGwR47W3IhbXBLx9VNwKyJCToKk=; b=D1ezAwCQdWikCBjgju6o MKf5b2KifEzr1FwhMpE9IeTydb6zWubmYva2CLJQuV1wkpjHx4LHArwCUCXHhr1pUE1RYdS/tTy6j Em8NlaRu3i8EG8q4N/h1Q8dxSH2qlvBlhVDYUHmn1HnuWsnsEZ5VtNmO/P5RphCgPRDn+4fEOxUr7 mgZCjvdhThhRIMIuIlGqbfdCry92HJG22s+zhq38bnLca3h3WOFJ/cn8p1JYBDYB5lnDhFZCxqPGN ZnZZum4jnbPam2ogJd+6dTfet02/quaEemUay0hmUhdsjF/1r/ZaQ3ThoJz6IFG+3q9aywBX2P+Y1 65UHrOVduOBUzQ==; In-Reply-To: (message from Yuan Fu on Fri, 10 Nov 2023 18:41:20 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274142 Archived-At: > Cc: Theodor Thornhill , 66988@debbugs.gnu.org, > Loïc Lemaître > From: Yuan Fu > Date: Fri, 10 Nov 2023 18:41:20 -0800 > > > Alternatively, treesit-thing-settings could be interpreted to imply full matches, then the code using it should not only match against the regexps but also check that the entire string (type name) is matched. > > I regret not doing this by default for treesit-indent-rules and traverse functions. Now it’s hard to change without creating confusion and breaking backward compatibility. I wonder if there are good way to smoothly transition to match full names by default… > > Treesit-thing-settings can be changed to match full names, but only if we can change treesit-indent-rules and friends too. Otherwise it would be too confusing. Is it feasible to have a variable that controls whether the full matches are implied in these APIs? Then we could start by making it optional, and at some later time make it the default.