From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66988: 30.0.50; treesit-forward-sexp not working properly in js-ts-mode and tsx-ts-mode Date: Sun, 19 Nov 2023 07:48:02 +0200 Message-ID: <83zfzal2el.fsf@gnu.org> References: <9cf7d7d0-33a3-4c07-bd66-bc4c59bdfefb@gmail.com> <39b0057b-ac0c-8271-0fe2-f4deef7ae8d3@gutov.dev> <83zfzkwxlv.fsf@gnu.org> <1C21FE6B-D54E-4301-AB87-5F15EE06D7D1@gmail.com> <83cywbryxi.fsf@gnu.org> <6042B192-0400-48E4-9290-940E019B01E3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32734"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66988@debbugs.gnu.org, mattias.engdegard@gmail.com, theo@thornhill.no, loic.lemaitre@gmail.com To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 19 06:49:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4agG-0008I3-SP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Nov 2023 06:49:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4ag3-0002Ya-TQ; Sun, 19 Nov 2023 00:49:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4ag2-0002YN-3x for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 00:49:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r4ag1-0001A3-87 for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 00:49:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r4ag2-0001Yx-EV for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 00:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2023 05:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66988 X-GNU-PR-Package: emacs Original-Received: via spool by 66988-submit@debbugs.gnu.org id=B66988.17003729175884 (code B ref 66988); Sun, 19 Nov 2023 05:49:02 +0000 Original-Received: (at 66988) by debbugs.gnu.org; 19 Nov 2023 05:48:37 +0000 Original-Received: from localhost ([127.0.0.1]:49772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4afc-0001Wl-Tr for submit@debbugs.gnu.org; Sun, 19 Nov 2023 00:48:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4afb-0001Vy-IN for 66988@debbugs.gnu.org; Sun, 19 Nov 2023 00:48:36 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4afU-00017L-KC; Sun, 19 Nov 2023 00:48:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ImpgpKeu+/OFOrdznwoG7F3JFkCWjlHOlJhsJFANeyM=; b=j3tvr4a9uU6FD9gz+ogJ zYULV2iIJyWZP7hMoGvGRZSRpl6BEDBZ4nG1rKAn0Wb7mMKl8V3BjuJLiqzZuJUkDYS06ay70Q5tM NvINV7kjvFndyVjX9TeileEqaLxtIdw0Fjf60JcRolmZiYLnhyCxalY1WEV75j/ukdsbOPUKEBVbL 47TM3jU5pMDPDCqxshrqTnwTUDWhiSHLb9U88Ee+Q0JSqcskSwDMKzJM8rnSsj8pHB7WKDTfYlVYv aJYeIWjtatzvmdmOUvSmhe70xgggj+/8+ZT8sNuJqlmkgmaFkkS+KkiXbzAQ4DxoXVqX2HOV00hUp 62ullMdK83U1BA==; In-Reply-To: <6042B192-0400-48E4-9290-940E019B01E3@gmail.com> (message from Yuan Fu on Sat, 18 Nov 2023 10:57:56 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274587 Archived-At: > From: Yuan Fu > Date: Sat, 18 Nov 2023 10:57:56 -0800 > Cc: Dmitry Gutov , > Theodor Thornhill , > 66988@debbugs.gnu.org, > Loïc Lemaître , > Mattias Engdegård > > > > > On Nov 15, 2023, at 4:19 AM, Eli Zaretskii wrote: > > > >> From: Yuan Fu > >> Date: Tue, 14 Nov 2023 22:28:34 -0800 > >> Cc: Dmitry Gutov , > >> Theodor Thornhill , > >> 66988@debbugs.gnu.org, > >> loic.lemaitre@gmail.com > >> > >>> Is it feasible to have a variable that controls whether the full > >>> matches are implied in these APIs? Then we could start by making it > >>> optional, and at some later time make it the default. > >> > >> It’s feasible, but I don’t think it’s TRT. The major mode author should have the control over whether the full match is implied, not the user. It doesn’t make sense to toggle the variable either. If you change that variable, major mode code must also change to be correct. > > > > So what do you suggest that we do about this issue? > > We change every treesit function that takes a regexp for matching node type names to imply full match. I think most people wrote code as if these functions use full match, so the breakage should be small. And I can forecast this change in as many channels as I can. Fine by me, so let's do it.