From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Sat, 23 Dec 2023 13:16:37 +0200 Message-ID: <83zfy1cgoa.fsf@gnu.org> References: <878r919qfh.fsf@localhost> <834jjm749q.fsf@gnu.org> <87cyyawd1a.fsf@localhost> <83pm2a5k85.fsf@gnu.org> <87wmwh2tae.fsf@localhost> <83zg1d468w.fsf@gnu.org> <87bkdr2651.fsf@localhost> <87pm2584oz.fsf@localhost> <83cyy11ln1.fsf@gnu.org> <87lecp84mf.fsf@localhost> <83ttrdx8j9.fsf@gnu.org> <87a5su261p.fsf@localhost> <838r8e24yy.fsf@gnu.org> <87y1gezspg.fsf@localhost> <834jj21z05.fsf@gnu.org> <87il7izo4l.fsf@localhost> <831qe61xrh.fsf@gnu.org> <87cyxqzmhh.fsf@localhost> <83zg0uzlgw.fsf@gnu.org> <87v8bhxzcu.fsf@localhost> <83sf3te1tu.fsf@gnu.org> <87msu1qmqv.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38413"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org, monnier@iro.umontreal.ca To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 23 12:18:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rH01K-0009pe-4g for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Dec 2023 12:18:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rH011-0000cC-KJ; Sat, 23 Dec 2023 06:17:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rH00y-0000c1-OY for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 06:17:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rH00y-0007IR-GA for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 06:17:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rH013-00075F-K2 for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 06:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Dec 2023 11:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.170333022127148 (code B ref 66117); Sat, 23 Dec 2023 11:18:01 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 23 Dec 2023 11:17:01 +0000 Original-Received: from localhost ([127.0.0.1]:48711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rH005-00073k-3k for submit@debbugs.gnu.org; Sat, 23 Dec 2023 06:17:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rH003-00073R-6B for 66117@debbugs.gnu.org; Sat, 23 Dec 2023 06:17:00 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGzzq-00078N-3y; Sat, 23 Dec 2023 06:16:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TX5v3tRhu08biZMlwVHo02KlUMn0rR9At30fqkGyxl8=; b=O3oRUE0rNbkm 9MufKcxjFCjtO5cQ14mh+FE5UHakWGlIU4749hwiIFKKzX3vWzMH4mRMP684hoZXDdGtebBYEhsZS 1AhSkEwejGHHi1pwkg8hO/HoBceLXG+tTd67ivPZyKD8kSD8aD+eQu0Wl3eoo2ukfZfXgudEPZ7/+ gQgnKevJ3kD/bFgISGfus0562k5WEGsU/G6rXhZLpXEx8i1cZ4U1jdQ1shCpr/Na/kGxRPWw0pgIZ y2WbJ2mI2rGUojB6kMh90CY8yVOgriHLTh1t3opCed+Hb9LIapK0WFDNy0LQ5Z6+iofv4Sxr+MrJr dfokSRWy7M2pWtIZvY/v2g==; In-Reply-To: <87msu1qmqv.fsf@localhost> (message from Ihor Radchenko on Sat, 23 Dec 2023 09:41:44 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276734 Archived-At: > From: Ihor Radchenko > Cc: Stefan Monnier , dmitry@gutov.dev, > 66117@debbugs.gnu.org > Date: Sat, 23 Dec 2023 09:41:44 +0000 > > Eli Zaretskii writes: > > >> > My advice is to have a prototype working, then time it on local > >> > filesystems. > >> > >> See the attached patch. > > > > What do we want to do with this? any reasons not to install this on > > master (and close this bug then)? > > I thought that it is already installed... The find-buffer part? I don't see it, did I miss something? > I do not think that we should close the bug even after installing the > patch for `find-buffer-visiting'. > > What I had in mind wrt improving `find-buffer-visiting' performance is: > > 1. Improve the Elisp part (this patch) Let's install it. > 2. Improve case-fold-search binding, which will give another speedup > (another patch I submitted) It should be installed, after you add the tests we've been discussing. > 3. Optionally add tests I hope the tests will not be optional... > 4. Address the scenario Dmitry described in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66117#91 That could be a separate bug report. This one is already too long, and includes too many different issues.