From: Eli Zaretskii <eliz@gnu.org>
To: Jared Finder <jared@finder.org>
Cc: 67856-done@debbugs.gnu.org
Subject: bug#67856: Dired navigation via directory line does not respect dired-kill-when-opening-new-dired-buffer
Date: Mon, 25 Dec 2023 15:08:27 +0200 [thread overview]
Message-ID: <83zfxya0qc.fsf@gnu.org> (raw)
In-Reply-To: <9b86ffe265056857ab5ada6870451f84@finder.org> (message from Jared Finder on Sun, 24 Dec 2023 12:11:49 -0800)
> Date: Sun, 24 Dec 2023 12:11:49 -0800
> From: Jared Finder <jared@finder.org>
> Cc: 67856@debbugs.gnu.org
>
> On 2023-12-21 05:18, Eli Zaretskii wrote:
> >> Date: Sat, 16 Dec 2023 12:35:10 -0800
> >> From: Jared Finder via "Bug reports for GNU Emacs,
> >> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >>
> >> The option dired-kill-when-opening-new-dired-buffer is not respected
> >> when clicking on parent directories in the directory line at the top
> >> of dired buffers. This can be fixed by calling
> >> dired--find-possibly-alternate-file instead of dired in the
> >> callback, as my attached patch does.
> >>
> >> I believe changing to dired--find-possibly-alternate-file is safe
> >> because from playing around with dired, the directory being clicked
> >> on must be a directory and can not contain wildcards at this point.
> >> Therefore, at this point it is known that the directory is just a
> >> plain directory (no wildcards) and so going through find-file
> >> machinery will have the intended result.
> >
> > If we want to install this on the emacs-29 release branch, I'd prefer
> > a safer variant, which actually verified that we don't call
> > dired--find-possibly-alternate-file with a wildcard. That's because
> > we have quite a few features that place buffers in Dired mode, and we
> > could easily miss one that does have wildcards there.
> >
> > So would you mind modifying the patch a little so that it checks
> > whether current-dir includes wildcards, and if so, calls 'dired'
> > instead of dired--find-possibly-alternate-file?
>
> Done, new patch attached. Luckily, there already is a function that
> does exactly the right check.
>
> Feel free to alter the comment explaining why this third code path
> exists. I wasn't sure the right style to indicate this type of
> defensive code path that I am not certain is needed.
Thanks, installed on the emacs-29 branch with some minor reformatting,
and closing the bug.
prev parent reply other threads:[~2023-12-25 13:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 20:35 bug#67856: Dired navigation via directory line does not respect dired-kill-when-opening-new-dired-buffer Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-21 13:18 ` Eli Zaretskii
2023-12-24 20:11 ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-25 13:08 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zfxya0qc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67856-done@debbugs.gnu.org \
--cc=jared@finder.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).