From: Eli Zaretskii <eliz@gnu.org>
To: Nikolaj Schumacher <me@nschum.de>
Cc: 2993@emacsbugs.donarmstrong.com
Subject: bug#2993: 23.0.92; posn-col-row wrong with line-spacing in terminals
Date: Tue, 14 Apr 2009 16:59:34 +0300 [thread overview]
Message-ID: <83y6u3mj3t.fsf@gnu.org> (raw)
In-Reply-To: <m2r5zvqvs3.fsf@nschum.de>
> From: Nikolaj Schumacher <me@nschum.de>
> Cc: 2993@emacsbugs.donarmstrong.com
> Date: Tue, 14 Apr 2009 14:12:12 +0200
>
> Eli Zaretskii <eliz@gnu.org> wrote:
>
> >> posn-col-row uses the `line-spacing' value in terminals. According to the
> >> doc `line-spacing' only has an effect in window systems.
> >
> > You mean, on graphic displays.
>
> Yes.
>
> If that wording is inaccurate, it should also be fixed in the doc
> for `line-spacing', which says: "The space is measured in pixels, and
> put below lines on window systems."
Fixed. Thanks for pointing this out.
> --- a/lisp/subr.el
> +++ b/lisp/subr.el
> @@ -933,8 +933,10 @@ and `event-end' functions."
> (x (/ (car pair) (frame-char-width frame)))
> (y (/ (cdr pair) (+ (frame-char-height frame)
> (or (frame-parameter frame 'line-spacing)
> - ;; FIXME: Why the `default'?
> - (default-value 'line-spacing)
> + (when (display-graphic-p
> + (frame-terminal frame))
> + ;; FIXME: Why the `default'?
> + (default-value 'line-spacing))
> 0)))))
> (cons x y))))))
`display-graphic-p' accepts frames as its argument (see its doc
string ;-), so the extra call to `frame-terminal' is unnecessary.
Thanks.
next prev parent reply other threads:[~2009-04-14 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ab6hbknp.fsf@cyd.mit.edu>
2009-04-14 11:11 ` bug#2993: 23.0.92; posn-col-row wrong with line-spacing in terminals Nikolaj Schumacher
2009-04-14 11:32 ` Eli Zaretskii
2009-04-14 12:12 ` Nikolaj Schumacher
2009-04-14 13:59 ` Eli Zaretskii [this message]
2009-04-15 22:50 ` bug#2993: marked as done (23.0.92; posn-col-row wrong with line-spacing in terminals) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y6u3mj3t.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=2993@emacsbugs.donarmstrong.com \
--cc=me@nschum.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).