From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#6420: Some enhancements to debugging Date: Mon, 14 Jun 2010 20:58:33 +0300 Message-ID: <83y6ehijhy.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1276540545 29364 80.91.229.12 (14 Jun 2010 18:35:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 14 Jun 2010 18:35:45 +0000 (UTC) Cc: 6420@debbugs.gnu.org To: Lennart Borgman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 14 20:35:44 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OOEVb-0005tn-TL for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Jun 2010 20:35:44 +0200 Original-Received: from localhost ([127.0.0.1]:52839 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOEQo-0002IT-6Z for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Jun 2010 14:30:46 -0400 Original-Received: from [140.186.70.92] (port=39316 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOEOk-00035Q-Cr for bug-gnu-emacs@gnu.org; Mon, 14 Jun 2010 14:28:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOEOd-0008US-1K for bug-gnu-emacs@gnu.org; Mon, 14 Jun 2010 14:28:37 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44357) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOEOd-0008UL-01 for bug-gnu-emacs@gnu.org; Mon, 14 Jun 2010 14:28:31 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OODx5-00015v-KT; Mon, 14 Jun 2010 14:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Jun 2010 18:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6420 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6420-submit@debbugs.gnu.org id=B6420.12765383834187 (code B ref 6420); Mon, 14 Jun 2010 18:00:03 +0000 Original-Received: (at 6420) by debbugs.gnu.org; 14 Jun 2010 17:59:43 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OODwl-00015U-Eg for submit@debbugs.gnu.org; Mon, 14 Jun 2010 13:59:43 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OODwj-00015P-Ib for 6420@debbugs.gnu.org; Mon, 14 Jun 2010 13:59:42 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L4000C00N75KF00@a-mtaout22.012.net.il> for 6420@debbugs.gnu.org; Mon, 14 Jun 2010 20:58:31 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.127.88.125]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L400091DN9IQLA0@a-mtaout22.012.net.il>; Mon, 14 Jun 2010 20:58:31 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 14 Jun 2010 14:00:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37780 Archived-At: > From: Lennart Borgman > Date: Mon, 14 Jun 2010 08:11:59 +0200 > Cc: > > === modified file 'src/w32proc.c' > --- trunk/src/w32proc.c 2010-06-04 14:13:35 +0000 > +++ patched/src/w32proc.c 2010-06-14 05:53:50 +0000 > @@ -121,9 +121,17 @@ > { > char buf[1024]; > va_list args; > + char *buf_pos = buf; > + > + /* On NT add thread id */ > +#ifdef WINDOWSNT > + DWORD thread_id = GetCurrentThreadId (); > + sprintf (buf_pos, "[Th%04x] ", thread_id); > + buf_pos = buf_pos + 10; > +#endif The above #ifdef is unnecessary: all the platforms that compile this file have WINDOWSNT defined by definition. Also, why do you use magic constants such as 10, instead of the value returned by `sprintf'? > - DebPrint (("reader_thread.SetEvent failed with %lu for fd %ld\n", > - GetLastError (), cp->fd)); > + DebPrint (("reader_thread.SetEvent failed with %lu for fd %ld, pid %ld\n", > + GetLastError (), cp->fd, cp->pid)); cp->fd and cp->pid are both `int', so no need for `l' in `%ld'. Just use `%d'. > +If the message is longer than 1000 chars it will be split in several > +lines. Not really 1000, since you are prepending a thread ID, no?