unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#6944: Paste in Edit menu not active at start
@ 2010-08-30 10:32 Lennart Borgman
  2010-08-30 12:49 ` Stephen Berman
  2010-08-30 16:56 ` Eli Zaretskii
  0 siblings, 2 replies; 5+ messages in thread
From: Lennart Borgman @ 2010-08-30 10:32 UTC (permalink / raw)
  To: 6944

After starting Emacs with "emacs -Q" the "Paste" alternative is not
active in the menu even though C-y works.


In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2010-08-10
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags
-Ic:/g/include -fno-crossjumping'





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#6944: Paste in Edit menu not active at start
  2010-08-30 10:32 bug#6944: Paste in Edit menu not active at start Lennart Borgman
@ 2010-08-30 12:49 ` Stephen Berman
  2010-08-30 16:56 ` Eli Zaretskii
  1 sibling, 0 replies; 5+ messages in thread
From: Stephen Berman @ 2010-08-30 12:49 UTC (permalink / raw)
  To: Lennart Borgman; +Cc: 6944

On Mon, 30 Aug 2010 12:32:56 +0200 Lennart Borgman <lennart.borgman@gmail.com> wrote:

> After starting Emacs with "emacs -Q" the "Paste" alternative is not
> active in the menu even though C-y works.
>
>
> In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
>  of 2010-08-10
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> configured using `configure --with-gcc (3.4) --no-opt --cflags
> -Ic:/g/include -fno-crossjumping'

On GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.18.6) of
2010-08-22 on escher, "Paste" is active in the menu after starting with
-Q, so this seems to be an MS-Windows problem.

Steve Berman





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#6944: Paste in Edit menu not active at start
  2010-08-30 10:32 bug#6944: Paste in Edit menu not active at start Lennart Borgman
  2010-08-30 12:49 ` Stephen Berman
@ 2010-08-30 16:56 ` Eli Zaretskii
  2010-08-30 17:37   ` Chong Yidong
  1 sibling, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2010-08-30 16:56 UTC (permalink / raw)
  To: Lennart Borgman; +Cc: 6944

> From: Lennart Borgman <lennart.borgman@gmail.com>
> Date: Mon, 30 Aug 2010 12:32:56 +0200
> Cc: 
> 
> After starting Emacs with "emacs -Q" the "Paste" alternative is not
> active in the menu even though C-y works.

This happens because menu-bar.el defines the sensitivity of "Paste" as
follows:

  (define-key menu-bar-edit-menu [paste]
    `(menu-item ,(purecopy "Paste") yank
		:enable (and (or
			      ;; Emacs compiled --without-x doesn't have
			      ;; x-selection-exists-p.
			      (and (fboundp 'x-selection-exists-p)
				   (x-selection-exists-p))
			      kill-ring)
			     (not buffer-read-only))

and x-selection-exists-p with its argument omitted probes the PRIMARY
selection, which doesn't exist on MS-Windows.

I can easily fix that with an MS-Windows specific change, but I'm
actually surprised we don't call (x-selection-exists-p 'CLIPBOARD)
here: isn't C-y supposed to yank from the clipboard, not from PRIMARY?
If we use 'CLIPBOARD, the code will work on Windows without any
changes.

Am I missing something?





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#6944: Paste in Edit menu not active at start
  2010-08-30 16:56 ` Eli Zaretskii
@ 2010-08-30 17:37   ` Chong Yidong
  2010-08-30 18:12     ` Eli Zaretskii
  0 siblings, 1 reply; 5+ messages in thread
From: Chong Yidong @ 2010-08-30 17:37 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 6944

Eli Zaretskii <eliz@gnu.org> writes:

>   (define-key menu-bar-edit-menu [paste]
>     `(menu-item ,(purecopy "Paste") yank
> 		:enable (and (or
> 			      ;; Emacs compiled --without-x doesn't have
> 			      ;; x-selection-exists-p.
> 			      (and (fboundp 'x-selection-exists-p)
> 				   (x-selection-exists-p))
> 			      kill-ring)
> 			     (not buffer-read-only))
>
> I can easily fix that with an MS-Windows specific change, but I'm
> actually surprised we don't call (x-selection-exists-p 'CLIPBOARD)
> here: isn't C-y supposed to yank from the clipboard, not from PRIMARY?
> If we use 'CLIPBOARD, the code will work on Windows without any
> changes.

Yes, please make the change.  This looks like an oversight.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#6944: Paste in Edit menu not active at start
  2010-08-30 17:37   ` Chong Yidong
@ 2010-08-30 18:12     ` Eli Zaretskii
  0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2010-08-30 18:12 UTC (permalink / raw)
  To: Chong Yidong; +Cc: 6944-done

> From: Chong Yidong <cyd@stupidchicken.com>
> Cc: Lennart Borgman <lennart.borgman@gmail.com>, 6944@debbugs.gnu.org
> Date: Mon, 30 Aug 2010 13:37:52 -0400
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >   (define-key menu-bar-edit-menu [paste]
> >     `(menu-item ,(purecopy "Paste") yank
> > 		:enable (and (or
> > 			      ;; Emacs compiled --without-x doesn't have
> > 			      ;; x-selection-exists-p.
> > 			      (and (fboundp 'x-selection-exists-p)
> > 				   (x-selection-exists-p))
> > 			      kill-ring)
> > 			     (not buffer-read-only))
> >
> > I can easily fix that with an MS-Windows specific change, but I'm
> > actually surprised we don't call (x-selection-exists-p 'CLIPBOARD)
> > here: isn't C-y supposed to yank from the clipboard, not from PRIMARY?
> > If we use 'CLIPBOARD, the code will work on Windows without any
> > changes.
> 
> Yes, please make the change.  This looks like an oversight.

Done.





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-08-30 18:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-30 10:32 bug#6944: Paste in Edit menu not active at start Lennart Borgman
2010-08-30 12:49 ` Stephen Berman
2010-08-30 16:56 ` Eli Zaretskii
2010-08-30 17:37   ` Chong Yidong
2010-08-30 18:12     ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).