From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#1077: 23.0.60; x-create-frame: (wrong-type-argument number-or-marker-p nil) Date: Mon, 29 Nov 2010 23:18:34 +0200 Message-ID: <83y68b96c5.fsf@gnu.org> References: <003e01c9257c$a385d800$0200a8c0@us.oracle.com> <009701c9263f$9cce7120$0200a8c0@us.oracle.com> <000001c94cc1$e10e9c40$0200a8c0@us.oracle.com> <8F1F8998D60341099C4204B7BDD8AD4F@us.oracle.com> <96BC00F728B94AC18A15EA95B66C5248@us.oracle.com> <83zksv5g7j.fsf@gnu.org> <0A475933984F4CDA855D91C8B7639E3B@us.oracle.com> <83fwum5xzk.fsf@gnu.org> <9F24875655894485A414CD785D95725B@us.oracle.com> <83ipzh9qze.fsf@gnu.org> <4CF386C9.5070909@gmx.at> <8362vg9ctt.fsf@gnu.org> <4CF409A3.1030906@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1291067118 25626 80.91.229.12 (29 Nov 2010 21:45:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 29 Nov 2010 21:45:18 +0000 (UTC) Cc: 1077@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 29 22:45:11 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PNBX4-00042q-Hg for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Nov 2010 22:45:11 +0100 Original-Received: from localhost ([127.0.0.1]:38828 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNBX3-0004SG-Rv for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Nov 2010 16:45:09 -0500 Original-Received: from [140.186.70.92] (port=42081 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNBWv-0004R5-Iw for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 16:45:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNBWt-0001LB-Qz for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 16:45:01 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNBWt-0001L7-Nf for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 16:44:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PNB02-0006J1-77; Mon, 29 Nov 2010 16:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Nov 2010 21:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1077 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 1077-submit@debbugs.gnu.org id=B1077.129106505524226 (code B ref 1077); Mon, 29 Nov 2010 21:11:02 +0000 Original-Received: (at 1077) by debbugs.gnu.org; 29 Nov 2010 21:10:55 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PNAzu-0006Ih-1L for submit@debbugs.gnu.org; Mon, 29 Nov 2010 16:10:54 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PNAzq-0006IQ-D6 for 1077@debbugs.gnu.org; Mon, 29 Nov 2010 16:10:51 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LCO00A000DPFJ00@a-mtaout20.012.net.il> for 1077@debbugs.gnu.org; Mon, 29 Nov 2010 23:16:23 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.229.63.39]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LCO009HA0F97B80@a-mtaout20.012.net.il>; Mon, 29 Nov 2010 23:16:23 +0200 (IST) In-reply-to: <4CF409A3.1030906@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 29 Nov 2010 16:11:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42010 Archived-At: > Date: Mon, 29 Nov 2010 21:14:27 +0100 > From: martin rudalics > CC: drew.adams@oracle.com, 1077@debbugs.gnu.org > > > The frame we are creating is not yet ready, and is certainly not yet > > the selected frame! Isn't that a bug? shouldn't we use > > menu-updating-frame instead of nil, in the above call to > > frame-parameter? > > I think so. Hopefully `menu-updating-frame' has the correct parameters > in place. Any objections to the patch below? It fixes the error and the following crash with Drew's recipe. === modified file 'lisp/menu-bar.el' --- lisp/menu-bar.el 2010-08-13 13:26:13 +0000 +++ lisp/menu-bar.el 2010-11-29 21:08:59 +0000 @@ -966,7 +966,9 @@ mail status in mode line")) (define-key menu-bar-showhide-menu [menu-bar-mode] `(menu-item ,(purecopy "Menu-bar") toggle-menu-bar-mode-from-frame :help ,(purecopy "Turn menu-bar on/off") - :button (:toggle . (> (frame-parameter nil 'menu-bar-lines) 0)))) + :button (:toggle . (> (frame-parameter (or menu-updating-frame + (selected-frame)) + 'menu-bar-lines) 0)))) (defun menu-bar-set-tool-bar-position (position) (customize-set-variable 'tool-bar-mode t)