From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Uday S Reddy Newsgroups: gmane.emacs.bugs Subject: bug#8399: 23.3; save-some-buffers ignores buffer names Date: Thu, 31 Mar 2011 22:33:19 +0100 Message-ID: <83y63vm0v4.fsf@cs.bham.ac.uk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1301607464 4567 80.91.229.12 (31 Mar 2011 21:37:44 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 31 Mar 2011 21:37:44 +0000 (UTC) Cc: U.S.Reddy@cs.bham.ac.uk To: 8399@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 31 23:37:39 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5PYd-0007Yr-PQ for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Mar 2011 23:37:37 +0200 Original-Received: from localhost ([127.0.0.1]:49604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5PYc-0007bW-OG for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Mar 2011 17:37:34 -0400 Original-Received: from [140.186.70.92] (port=53973 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5PYI-0007Pu-An for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2011 17:37:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5PYG-0003Z7-LP for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2011 17:37:14 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5PYG-0003Z2-Jh for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2011 17:37:12 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q5PVC-0004ES-GS; Thu, 31 Mar 2011 17:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Uday S Reddy Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Mar 2011 21:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8399 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.130160723016247 (code B ref -1); Thu, 31 Mar 2011 21:34:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 31 Mar 2011 21:33:50 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5PUz-0004E0-0W for submit@debbugs.gnu.org; Thu, 31 Mar 2011 17:33:49 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q5PUw-0004Dn-Ap for submit@debbugs.gnu.org; Thu, 31 Mar 2011 17:33:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5PUp-00032E-IU for submit@debbugs.gnu.org; Thu, 31 Mar 2011 17:33:41 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:60739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5PUp-00032A-EI for submit@debbugs.gnu.org; Thu, 31 Mar 2011 17:33:39 -0400 Original-Received: from [140.186.70.92] (port=52287 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5PUn-0004lW-ML for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2011 17:33:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5PUl-00031q-Rr for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2011 17:33:37 -0400 Original-Received: from sun60.bham.ac.uk ([147.188.128.137]:51242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5PUl-00031U-JT for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2011 17:33:35 -0400 Original-Received: from [147.188.128.127] (helo=bham.ac.uk) by sun60.bham.ac.uk with esmtp (Exim 4.72) (envelope-from ) id 1Q5PUi-0004HV-NR for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2011 22:33:32 +0100 Original-Received: from mx1.cs.bham.ac.uk ([147.188.192.53]) by bham.ac.uk (envelope-from ) with esmtps (TLSv1:DES-CBC3-SHA:168) (Exim 4.72) id 1Q5PUi-0001oa-DO for bug-gnu-emacs@gnu.org using interface smart1.bham.ac.uk; Thu, 31 Mar 2011 22:33:32 +0100 Original-Received: from gromit.cs.bham.ac.uk ([147.188.193.16] helo=MARUTI.cs.bham.ac.uk) by mx1.cs.bham.ac.uk with esmtp (Exim 4.51) id 1Q5PUi-0006PB-R2; Thu, 31 Mar 2011 22:33:33 +0100 X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 31 Mar 2011 17:34:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45548 Archived-At: --=-=-= The save-some-buffers command queries the user as to which buffers should be saved. However, if the buffer has a file-name, it uses the file-name in the dialogue instead of the buffer name. If the buffer name happens to differ from the buffer's file-name, this is confusing to the users. (It happens quite frequently in VM, which uses obscure file-names for the caches of POP/IMAP folders, but the buffer names are recognizable.) The attached patch (on Emacs-23 head) modifies the dialogue so that file-names are used in the dialogue only when they coincide with the buffer names. Otherwise, buffer names are used preferentially. Cheers, Uday In GNU Emacs 23.3.1 (i386-mingw-nt5.1.2600) of 2011-03-10 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.5) --no-opt --cflags -Ic:/imagesupport/include' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: ENU value of $XMODIFIERS: nil locale-coding-system: cp1252 default enable-multibyte-characters: t Major mode: VM Presentation Minor modes in effect: diff-auto-refine-mode: t savehist-mode: t which-function-mode: t tooltip-mode: t mouse-wheel-mode: t use-hard-newlines: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t auto-encryption-mode: t line-number-mode: t visual-line-mode: t transient-mark-mode: t Recent input: y C-x C-f C-g C-x o C-x C-f C-g C-x o C-x C-f - d e v / b z r . l o SPC C-s f i l e s . e l C-a C-s 2 3 . 3 C-s C-s C-r C-r C-s C-s C-s C-r C-r C-r C-r C-r C-r C-r C-r C-r C-a C-x C-f N E SPC W SPC e t c / N E SPC C-l C-x k C-x o C-x b f i l e s . SPC C-g C-x o C-x C-r C-x , C-x o C-x b f i l e s . SPC C-x o M-x e d i f f - b u f n n n C-n C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-x o C-f C-f C-f C-f C-f C-f C-f C-f C-n C-f C-f C-f C-b C-b C-b C-b C-b C-a C-SPC C-n C-n C-n C-n C-n C-n C-n M-x u n t a b i f y q y C-x o M-x e d i f f - b u f n n n b q y C-x o C-x C-s C-a M-x r e p o r t - e m a c s - b u SPC Recent messages: Processing difference regions ... done Refining difference region 1 ... Refining difference region 2 ... Refining difference region 3 ... Saving old diff region #3 of buffer A. To recover, type `ra' [2 times] Only white-space differences in region 3 Quit this Ediff session? (y or n) Saving file d:/gnu/emacs-23-dev/lisp/files.el... Wrote d:/gnu/emacs-23-dev/lisp/files.el Mark set Load-path shadows: d:/Home/udr/share/emacs/sml-mode hides d:/gnu/emacs-23.3/../site-lisp/sml-mode d:/Home/udr/share/emacs/savehist-20+ hides d:/gnu/emacs-23.3/../site-lisp/savehist-20+ d:/gnu/emacs-23.3/../site-lisp/longlines hides d:/gnu/emacs-23.3/lisp/longlines d:/gnu/vm/trunk/lisp/cus-load hides d:/gnu/emacs-23.3/lisp/cus-load d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org hides d:/gnu/emacs-23.3/lisp/org/org d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-xoxo hides d:/gnu/emacs-23.3/lisp/org/org-xoxo d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-wl hides d:/gnu/emacs-23.3/lisp/org/org-wl d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-w3m hides d:/gnu/emacs-23.3/lisp/org/org-w3m d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-vm hides d:/gnu/emacs-23.3/lisp/org/org-vm d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-timer hides d:/gnu/emacs-23.3/lisp/org/org-timer d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-table hides d:/gnu/emacs-23.3/lisp/org/org-table d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-src hides d:/gnu/emacs-23.3/lisp/org/org-src d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-rmail hides d:/gnu/emacs-23.3/lisp/org/org-rmail d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-remember hides d:/gnu/emacs-23.3/lisp/org/org-remember d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-publish hides d:/gnu/emacs-23.3/lisp/org/org-publish d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-protocol hides d:/gnu/emacs-23.3/lisp/org/org-protocol d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-plot hides d:/gnu/emacs-23.3/lisp/org/org-plot d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-mouse hides d:/gnu/emacs-23.3/lisp/org/org-mouse d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-mobile hides d:/gnu/emacs-23.3/lisp/org/org-mobile d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-mhe hides d:/gnu/emacs-23.3/lisp/org/org-mhe d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-mew hides d:/gnu/emacs-23.3/lisp/org/org-mew d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-macs hides d:/gnu/emacs-23.3/lisp/org/org-macs d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-mac-message hides d:/gnu/emacs-23.3/lisp/org/org-mac-message d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-list hides d:/gnu/emacs-23.3/lisp/org/org-list d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-latex hides d:/gnu/emacs-23.3/lisp/org/org-latex d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-jsinfo hides d:/gnu/emacs-23.3/lisp/org/org-jsinfo d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-irc hides d:/gnu/emacs-23.3/lisp/org/org-irc d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-install hides d:/gnu/emacs-23.3/lisp/org/org-install d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-inlinetask hides d:/gnu/emacs-23.3/lisp/org/org-inlinetask d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-info hides d:/gnu/emacs-23.3/lisp/org/org-info d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-indent hides d:/gnu/emacs-23.3/lisp/org/org-indent d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-id hides d:/gnu/emacs-23.3/lisp/org/org-id d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-icalendar hides d:/gnu/emacs-23.3/lisp/org/org-icalendar d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-html hides d:/gnu/emacs-23.3/lisp/org/org-html d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-habit hides d:/gnu/emacs-23.3/lisp/org/org-habit d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-gnus hides d:/gnu/emacs-23.3/lisp/org/org-gnus d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-freemind hides d:/gnu/emacs-23.3/lisp/org/org-freemind d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-footnote hides d:/gnu/emacs-23.3/lisp/org/org-footnote d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-feed hides d:/gnu/emacs-23.3/lisp/org/org-feed d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-faces hides d:/gnu/emacs-23.3/lisp/org/org-faces d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-exp hides d:/gnu/emacs-23.3/lisp/org/org-exp d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-exp-blocks hides d:/gnu/emacs-23.3/lisp/org/org-exp-blocks d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-docbook hides d:/gnu/emacs-23.3/lisp/org/org-docbook d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-datetree hides d:/gnu/emacs-23.3/lisp/org/org-datetree d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-crypt hides d:/gnu/emacs-23.3/lisp/org/org-crypt d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-compat hides d:/gnu/emacs-23.3/lisp/org/org-compat d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-colview hides d:/gnu/emacs-23.3/lisp/org/org-colview d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-clock hides d:/gnu/emacs-23.3/lisp/org/org-clock d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-bibtex hides d:/gnu/emacs-23.3/lisp/org/org-bibtex d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-bbdb hides d:/gnu/emacs-23.3/lisp/org/org-bbdb d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-attach hides d:/gnu/emacs-23.3/lisp/org/org-attach d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-ascii hides d:/gnu/emacs-23.3/lisp/org/org-ascii d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-archive hides d:/gnu/emacs-23.3/lisp/org/org-archive d:/gnu/emacs-23.3/../packages/org-7.4/lisp/org-agenda hides d:/gnu/emacs-23.3/lisp/org/org-agenda d:/Home/udr/share/emacs/rnews hides d:/gnu/emacs-23.3/lisp/obsolete/rnews Features: (shadow sort message ecomplete mml mml-sec password-cache mm-decode mm-bodies mm-encode mailcap nnheader gmm-utils mailheader canlock hashcash mail-utils warnings emacsbug tabify smerge-mode diff-mode noutline outline multi-isearch ediff-merg ediff-diff ediff-wind ediff-help ediff-util ediff-mult ediff-init ediff cl-specs edebug find-func help-mode view vm-pop vm-mark vm-delete bbdb-hooks mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mm-util mail-prsvr longlines easy-mmode w3m-form w3m browse-url doc-view dired-x dired-aux mydired dired image-mode w3m-hist w3m-fb bookmark-w3m w3m-ems wid-edit w3m-ccl ccl w3m-favicon w3m-image w3m-proc w3m-util vm-w3m tapestry vm-sort vm-thread vm-crypto vm-imap easymenu u-vm-color my-vm vc-bzr sha1 hex-util etags ps-print ps-def lpr vm-save vm-ps-print vm-rfaddons vm-menu vm-window vm-toolbar vm-folder vm-mime vm-undo vm-virtual vm-summary-faces vm-mouse vm-page vm-minibuf vm-message vm-misc vm-macro bbdb-vm vm-summary vm-motion vm-autoload bbdb-snarf mail-extr rfc822 bbdb-com advice help-fns advice-preload mailabbrev cl cl-19 vm server w3m-load bbdb-autoloads bbdb timezone vm-autoloads vm-version vm-vars org-install savehist tex-site tex-mik telnet movement natural-space NatSpeak sendmail auth-source gnus-util netrc time-date epa-file epa epg epg-config ange-ftp regexp-opt comint ring echistory chistory ehelp electric derived which-func imenu edmacro kmacro jka-compr tooltip ediff-hook vc-hooks lisp-float-type mwheel dos-w32 disp-table ls-lisp w32-win w32-vars tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process multi-tty emacs) -- --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=save-some-buffers.diff Content-Description: patch for save-some-buffers in files.el === modified file 'lisp/files.el' --- lisp/files.el 2011-03-11 12:19:08 +0000 +++ lisp/files.el 2011-03-31 21:23:03 +0000 @@ -4511,7 +4511,10 @@ (if arg t (setq queried t) - (if (buffer-file-name buffer) + (if (and (buffer-file-name buffer) + (equal (buffer-name buffer) + (file-name-nondirectory + (buffer-file-name buffer)))) (format "Save file %s? " (buffer-file-name buffer)) (format "Save buffer %s? " --=-=-=--