From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12792: 24.2.50; shell-mode renders all its output in a yellow face Date: Sat, 03 Nov 2012 18:32:51 +0200 Message-ID: <83y5ii4pfw.fsf@gnu.org> References: <871ugbxdyr.fsf@secretsauce.net> <85r4oazoh4.fsf@iznogoud.viz> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1351960453 7220 80.91.229.3 (3 Nov 2012 16:34:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 Nov 2012 16:34:13 +0000 (UTC) Cc: 12792@debbugs.gnu.org, dima@secretsauce.net To: Wolfgang Jenkner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 03 17:34:22 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TUgfs-0006Fk-QF for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Nov 2012 17:34:20 +0100 Original-Received: from localhost ([::1]:60275 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUgfj-00011C-US for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Nov 2012 12:34:11 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUgfh-00010u-1x for bug-gnu-emacs@gnu.org; Sat, 03 Nov 2012 12:34:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TUgff-00082c-SR for bug-gnu-emacs@gnu.org; Sat, 03 Nov 2012 12:34:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUgff-00082U-NE for bug-gnu-emacs@gnu.org; Sat, 03 Nov 2012 12:34:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TUgiU-0002R0-9K for bug-gnu-emacs@gnu.org; Sat, 03 Nov 2012 12:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Nov 2012 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12792 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12792-submit@debbugs.gnu.org id=B12792.13519605629280 (code B ref 12792); Sat, 03 Nov 2012 16:37:02 +0000 Original-Received: (at 12792) by debbugs.gnu.org; 3 Nov 2012 16:36:02 +0000 Original-Received: from localhost ([127.0.0.1]:47343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUghW-0002PZ-14 for submit@debbugs.gnu.org; Sat, 03 Nov 2012 12:36:02 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:40133) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUghS-0002PJ-Iw for 12792@debbugs.gnu.org; Sat, 03 Nov 2012 12:36:00 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MCX00F0073OMO00@a-mtaout23.012.net.il> for 12792@debbugs.gnu.org; Sat, 03 Nov 2012 18:33:02 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MCX00FZ27B1IZ50@a-mtaout23.012.net.il>; Sat, 03 Nov 2012 18:33:02 +0200 (IST) In-reply-to: <85r4oazoh4.fsf@iznogoud.viz> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66387 Archived-At: > From: Wolfgang Jenkner > Date: Sat, 03 Nov 2012 16:37:59 +0100 > Cc: 12792@debbugs.gnu.org > > In bug#11883 you give this example > > echo -e "\033[31mtest\033[39m" > > but ansi-color has never supported SGR parameter 39. However, before my > change (the latter commit above), any unknown parameter would have the > same effect as parameter 0 (turn off all rendition aspects), while it is > simply ignored now (well, except for an "Invalid face reference: nil" > message), see `ansi-color-apply-sequence'. Perhaps, this explains the > problem. SGR parameter 39 means go back to the default foreground color. How can ansi-color not support it and still be useful? IIUC, what the old code did was exactly the right thing (or at least close, since 0 means turn off _all_ attributes, not just the foreground color), so removing it without replacing it with something that restores the default foreground would be a bug, IMO.