unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Oleksandr Gavenko <gavenkoa@gmail.com>
Cc: 12927@debbugs.gnu.org
Subject: bug#12927: 24.2; global-hl-line-mode and "scroll-conservatively=1000" take	jump	up-down the text when hold DOWN key (in *info* buffer).
Date: Tue, 20 Nov 2012 22:47:56 +0200	[thread overview]
Message-ID: <83y5hwuhkz.fsf@gnu.org> (raw)
In-Reply-To: <87zk2c57v9.fsf@gavenkoa.example.com>

> From: Oleksandr Gavenko <gavenkoa@gmail.com>
> Cc: 12927@debbugs.gnu.org
> Date: Tue, 20 Nov 2012 22:36:58 +0200
> 
> > Should be fixed in revision 110927 on the emacs-24 branch.  Please
> > test.
> 
> I don't familiar with bzr:
> 
>   $ bzr up
>   $ bzr info -v
>   Repository checkout (format: 2a)
>   Location:
>     repository checkout root: .
>           checkout of branch: bzr://bzr.savannah.gnu.org/emacs/trunk/
>            shared repository: /home/user/devel/emacs/emacs-bzr

This is the trunk, not the emacs-24 branch.  I committed the fix to
the emacs-24 branch.  You can wait until the changes from the branch
are merged onto the trunk, and test then.  Or you can checkout the
branch, like so:

  $ cd /home/user/devel/emacs/emacs-bzr
  $ bzr branch bzr://bzr.savannah.gnu.org/emacs/emacs-24

This will create an emacs-24 directory under
/home/user/devel/emacs/emacs-bzr, and you can then build it and try
the fix.

> Also I found that "(global-hl-line-mode 1)" slow down scrolling in CC-mode
> enabled buffers in two or more times. Do I need report a bug?

No, this is expected.  hl-line-mode adds itself to post-command-hook,
and moves its overlay after each command that changes the current
line.  What this does is completely disable the redisplay
optimizations used when only the cursor moves without any other
changes to the text, because moving an overlay requires a thorough
redisplay of the window, which is more expensive.

The only bug report that I can think of is a feature request to move
hl-line-mode into the display engine, because the display engine
knowns very well where's the current line (when it decides where to
display the cursor), and can do this highlighting better and much more
efficiently.





  reply	other threads:[~2012-11-20 20:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-18 21:13 bug#12927: 24.2; global-hl-line-mode and "scroll-conservatively=1000" take jump up-down the text when hold DOWN key (in *info* buffer) Oleksandr Gavenko
2012-11-19 16:43 ` Eli Zaretskii
2012-11-20 17:46   ` Eli Zaretskii
2012-11-20 20:36     ` Oleksandr Gavenko
2012-11-20 20:47       ` Eli Zaretskii [this message]
2012-11-21 13:51         ` Stefan Monnier
2012-11-21 22:14         ` Oleksandr Gavenko
2012-11-22  3:45           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y5hwuhkz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=12927@debbugs.gnu.org \
    --cc=gavenkoa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).