From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@jurta.org>
Cc: sdl.web@gmail.com, 13000@debbugs.gnu.org
Subject: bug#13000: 24.2.90; underwave doesn't look as good as other IDEs
Date: Sat, 29 Dec 2012 09:19:20 +0200 [thread overview]
Message-ID: <83y5ghl407.fsf@gnu.org> (raw)
In-Reply-To: <87vcbl3er7.fsf@mail.jurta.org>
> From: Juri Linkov <juri@jurta.org>
> Date: Sat, 29 Dec 2012 01:54:28 +0200
> Cc: 13000@debbugs.gnu.org
>
> One problem is how to handle the tty case. On a tty frame
> underwave underlines and doesn't use the color attribute.
> So the question is what face condition to use to filter out
> displays where underwave is not supported.
>
> The already supported condition ((supports :underline t))
> doesn't take into account the underwave attribute,
> and a similar condition ((supports :underline wave))
> is not implemented.
Implementing the missing condition should be easy.
> Thus the patch uses the condition ((class color) (min-colors 88))
> to find the displays that should use the old face definitions
> without underwave:
This will do the wrong thing on 256-color xterm, I think.
next prev parent reply other threads:[~2012-12-29 7:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 3:21 bug#13000: 24.2.90; underwave doesn't look as good as other IDEs Leo
2012-12-26 6:31 ` Leo
2012-12-27 8:33 ` Leo
2012-12-27 19:33 ` Juri Linkov
2012-12-28 9:06 ` Leo
2012-12-28 23:54 ` Juri Linkov
2012-12-29 6:45 ` Leo
2012-12-29 7:19 ` Eli Zaretskii [this message]
2012-12-29 21:54 ` Juri Linkov
2013-01-04 1:47 ` Leo Liu
2013-01-08 23:51 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y5ghl407.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=13000@debbugs.gnu.org \
--cc=juri@jurta.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).