From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#16479: 24.3.50; daemon freeze with tty menus Date: Mon, 20 Jan 2014 21:35:22 +0200 Message-ID: <83y52ah2f9.fsf@gnu.org> References: <87y52fgd5g.fsf@holos.localdomain> <83ha93kk5m.fsf@gnu.org> <87eh4652o0.fsf@holos.localdomain> <83fvomlv7w.fsf@gnu.org> <83eh46lsy5.fsf@gnu.org> <838uueljdv.fsf@gnu.org> <834n52l9qh.fsf@gnu.org> <8361peilxe.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1390246977 8552 80.91.229.3 (20 Jan 2014 19:42:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 20 Jan 2014 19:42:57 +0000 (UTC) Cc: mvoteiza@udel.edu, 16479@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 20 20:43:03 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W5KkN-0005rf-BH for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Jan 2014 20:42:59 +0100 Original-Received: from localhost ([::1]:54352 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5KkM-00008Y-Uj for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Jan 2014 14:42:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5Kdj-0007hX-9Z for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2014 14:36:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5Kde-0006PA-H1 for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2014 14:36:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5Kde-0006Oz-Dm for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2014 14:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W5Kdd-0005eR-V4 for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2014 14:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jan 2014 19:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16479 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16479-submit@debbugs.gnu.org id=B16479.139024652221668 (code B ref 16479); Mon, 20 Jan 2014 19:36:01 +0000 Original-Received: (at 16479) by debbugs.gnu.org; 20 Jan 2014 19:35:22 +0000 Original-Received: from localhost ([127.0.0.1]:58722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W5Kcy-0005dO-CY for submit@debbugs.gnu.org; Mon, 20 Jan 2014 14:35:21 -0500 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:48590) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W5Kct-0005d8-BN for 16479@debbugs.gnu.org; Mon, 20 Jan 2014 14:35:16 -0500 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0MZP00L00SYJAX00@mtaout28.012.net.il> for 16479@debbugs.gnu.org; Mon, 20 Jan 2014 21:36:22 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MZP00JHGT4M3J30@mtaout28.012.net.il>; Mon, 20 Jan 2014 21:36:22 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83814 Archived-At: > From: Stefan Monnier > Cc: mvoteiza@udel.edu, 16479@debbugs.gnu.org > Date: Mon, 20 Jan 2014 13:27:00 -0500 > > > I'm unsure how best to handle this mess. Maybe avoid selecting the > > new frame in server-create-tty-frame, if a TTY menu is currently being > > displayed? > > Whatever we do, we should do it whether or not a tty menu is displayed. > Switching frame inside a process filter is nasty but allowed. So: > - server.el should probably only change the selected frame temporarily and > revert it before returning from the process filter. But I think server.el does this on purpose: if it didn't switch to the new frame, you couldn't start typing into it after invoking emacsclient, even when there's no menu displayed. Wouldn't that be confusing? > - tty menus need to make sure they don't crash if a process filter > changes the selected frame. That is easy. > But I think it's OK if they behave a bit strangely in that case. Does the fact that you type into one frame and get response in another count as "a bit strangely"? Then we don't need to do anything except to add some simple detection of the frame switch, see below. > IIUC with your recent change it doesn't crash any more, so it > might be good enough on this side. The crash happened because the frame switch went unnoticed, and we tried to use face IDs from one frame on another. This no longer happens, and I will add a simple code that will quit the menu when it sees a frame switch. Thanks.