From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17839: 24.4.50; read-passwd echoes password input in non-interactive sessions Date: Fri, 11 Jul 2014 13:13:51 +0300 Message-ID: <83y4w09p9c.fsf@gnu.org> References: <53FA2CB5-2009-4F77-B10D-03B16CE6D715@lunaryorn.com> <87fvi9jn5w.fsf@gmx.de> <87vbr48del.fsf@gmx.de> <834myob55h.fsf@gnu.org> <87mwcg8bdw.fsf@gmx.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1405073734 3381 80.91.229.3 (11 Jul 2014 10:15:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Jul 2014 10:15:34 +0000 (UTC) Cc: schwab@suse.de, 17839@debbugs.gnu.org, swiesner@lunaryorn.com To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 11 12:15:26 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X5XrP-0000VD-MR for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Jul 2014 12:15:23 +0200 Original-Received: from localhost ([::1]:43780 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5XrP-00067B-6Y for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Jul 2014 06:15:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5XrA-0005lc-5N for bug-gnu-emacs@gnu.org; Fri, 11 Jul 2014 06:15:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X5Xr5-0006Ow-ER for bug-gnu-emacs@gnu.org; Fri, 11 Jul 2014 06:15:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X5Xr5-0006OI-9b for bug-gnu-emacs@gnu.org; Fri, 11 Jul 2014 06:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X5Xr4-0000Zu-Vm for bug-gnu-emacs@gnu.org; Fri, 11 Jul 2014 06:15:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jul 2014 10:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17839-submit@debbugs.gnu.org id=B17839.14050736422111 (code B ref 17839); Fri, 11 Jul 2014 10:15:02 +0000 Original-Received: (at 17839) by debbugs.gnu.org; 11 Jul 2014 10:14:02 +0000 Original-Received: from localhost ([127.0.0.1]:53032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Xq3-0000XV-83 for submit@debbugs.gnu.org; Fri, 11 Jul 2014 06:14:02 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:41054) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X5Xpy-0000X8-6N for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 06:13:57 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0N8J00J00LDVUC00@a-mtaout20.012.net.il> for 17839@debbugs.gnu.org; Fri, 11 Jul 2014 13:13:47 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8J00JK1LQZOO50@a-mtaout20.012.net.il>; Fri, 11 Jul 2014 13:13:47 +0300 (IDT) In-reply-to: <87mwcg8bdw.fsf@gmx.de> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91436 Archived-At: > From: Michael Albinus > Cc: monnier@iro.umontreal.ca, schwab@suse.de, 17839@debbugs.gnu.org, swiesner@lunaryorn.com > Date: Fri, 11 Jul 2014 11:58:51 +0200 > > Eli Zaretskii writes: > > > Which breaks the MS-Windows build, of course, since Windows doesn't > > have termios. > > That's what I have said my first message: I could test it for Gnu/Linux only. Testing on GNU/Linux is not the same as installing Posix-only code in a function that is compiled on non-Posix platforms. > Shall I add "#ifndef WINDOWSNT" at the usual places? I already did that. > Alternatively, shall we add (disable|enable)_echo functions to sysdep.c? Yes, please. This will make emulating termios for Windows easier. Thanks.