From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21435: 25.0.50; file-notify has problems after renames Date: Sun, 20 Sep 2015 22:36:29 +0300 Message-ID: <83y4g0opc2.fsf@gnu.org> References: <87y4gh47sr.fsf@gnu.org> <878u81ngsi.fsf@gmx.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1442777962 2090 80.91.229.3 (20 Sep 2015 19:39:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Sep 2015 19:39:22 +0000 (UTC) Cc: 21435@debbugs.gnu.org, tsdh@gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 20 21:39:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZdkS7-0001Fp-Eh for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Sep 2015 21:39:11 +0200 Original-Received: from localhost ([::1]:53351 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdkS6-0005oE-Ma for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Sep 2015 15:39:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdkS2-0005o8-2E for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2015 15:39:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZdkRy-0003qO-Rx for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2015 15:39:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdkRy-0003qK-Oh for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2015 15:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZdkRy-00025K-F5 for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2015 15:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Sep 2015 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21435 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21435-submit@debbugs.gnu.org id=B21435.14427778917946 (code B ref 21435); Sun, 20 Sep 2015 19:39:02 +0000 Original-Received: (at 21435) by debbugs.gnu.org; 20 Sep 2015 19:38:11 +0000 Original-Received: from localhost ([127.0.0.1]:39143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZdkR9-000245-8k for submit@debbugs.gnu.org; Sun, 20 Sep 2015 15:38:11 -0400 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:47329) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZdkR5-00023v-27 for 21435@debbugs.gnu.org; Sun, 20 Sep 2015 15:38:08 -0400 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NUZ00P00Q4L7Z00@mtaout24.012.net.il> for 21435@debbugs.gnu.org; Sun, 20 Sep 2015 22:29:09 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NUZ00O7YQ4LSI00@mtaout24.012.net.il>; Sun, 20 Sep 2015 22:29:09 +0300 (IDT) In-reply-to: <878u81ngsi.fsf@gmx.de> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106747 Archived-At: > From: Michael Albinus > Date: Sun, 20 Sep 2015 19:26:21 +0200 > Cc: 21435@debbugs.gnu.org > > Tassilo Horn writes: > > > file-notify using the inotify backend reports wrong events after > > directory renames. > > This is also fixed, the test case for inotify and Tramp pass. So the bug > report could be closed once there is a final confirmation for w32notify. w32notify reports 2 changed events in a row: Test file-notify-test02-events condition: (ert-test-failed ((should (equal '... (mapcar ... events))) :form (equal (created changed deleted) (created changed changed deleted)) :value nil :explanation (proper-lists-of-different-length 3 4 (created changed deleted) (created changed changed deleted) first-mismatch-at 2))) This is the "copy" part of the test. Interestingly, sometimes there are 2 separate "changed" events and sometimes only 1. Does filenotify.el try to conflate several consecutive events of the same kind into one? In any case, I guess we will have to allow either one or 2 "changed" events there. The other parts also have differences. Here are the diffs I need to make all the tests pass: diff --git a/test/automated/file-notify-tests.el b/test/automated/file-notify-tests.el index 9d66f03..1aaf4b7 100644 --- a/test/automated/file-notify-tests.el +++ b/test/automated/file-notify-tests.el @@ -286,7 +286,7 @@ (ert-deftest file-notify-test02-events () (file-notify--test-with-events 3 (file-notify--test-timeout) (lambda (events) - (should (equal '(created changed deleted) + (should (equal '(created changed changed deleted) (mapcar #'cadr events)))) (write-region "any text" nil file-notify--test-tmpfile nil 'no-message) @@ -318,7 +318,7 @@ (ert-deftest file-notify-test02-events () (file-notify--test-with-events 2 (file-notify--test-timeout) (lambda (events) - (should (equal '(attribute-changed attribute-changed) + (should (equal '(changed changed changed) (mapcar #'cadr events)))) (write-region "any text" nil file-notify--test-tmpfile nil 'no-message) @@ -331,9 +331,9 @@ (ert-deftest file-notify-test02-events () ;; `file-notify--test-events' has been set correctly. (should (equal (mapcar #'cadr file-notify--test-events) '(created changed deleted - created changed deleted + created changed changed deleted created changed renamed - attribute-changed attribute-changed))) + changed changed changed))) (should file-notify--test-results) (dolist (result file-notify--test-results)