unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Shakthi Kannan <shakthimaan@gmail.com>
Cc: 9130@debbugs.gnu.org
Subject: bug#9130: Document Lisp mode fontification for strings after :documentation
Date: Wed, 16 Dec 2015 19:53:00 +0200	[thread overview]
Message-ID: <83y4cuz3er.fsf@gnu.org> (raw)
In-Reply-To: <CABG-yt0D+5ffkm5USvQ=v7vD1dKjC85n-uvJfH=2_wFkRt9RHg@mail.gmail.com> (message from Shakthi Kannan on Wed, 16 Dec 2015 22:40:30 +0530)

> Date: Wed, 16 Dec 2015 22:40:30 +0530
> From: Shakthi Kannan <shakthimaan@gmail.com>
> 
> Attached patch that updates etc/NEWS for fontification of strings
> after :documentation in Lisp mode.

Thanks.  A couple of comments:

> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -631,7 +631,13 @@ respectively, `show-paren-when-point-inside-paren' or
>  `show-paren-when-point-in-periphery'.
>  
>  ** Lisp mode
> -*** Strings after `:documentation' are highlighted as docstrings.
> +
> ++++
> +*** Strings after `:documentation' are highlighted as docstrings. This
> +enhances Lisp mode fontification to handle documentation of the form
> +(:documentation "the doc string") used in Common Lisp code for CLOS
> +class and slot documentation.

The first sentence should be alone on its line, with the rest in the
following lines.

Also, you are marking this as documented, but in what manual did you
find this documented?  The original commit that added this feature
didn't include any documentation changes.





  reply	other threads:[~2015-12-16 17:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-20 16:50 bug#9130: 23.3; Lisp mode doc string enhancment Robert Brown
2011-08-02 20:01 ` Stefan Monnier
2014-03-25 17:54   ` Robert Brown
2014-06-19 14:04     ` bug#9130: 23.3; Lisp mode doc string enhancement Stefan Monnier
2015-12-16 17:10 ` bug#9130: Document Lisp mode fontification for strings after :documentation Shakthi Kannan
2015-12-16 17:53   ` Eli Zaretskii [this message]
2015-12-16 18:07     ` Shakthi Kannan
2015-12-16 18:47       ` Eli Zaretskii
2015-12-16 18:54         ` Shakthi Kannan
2015-12-16 18:56           ` Eli Zaretskii
2015-12-17 16:59             ` Shakthi Kannan
2015-12-18 15:35               ` Eli Zaretskii
2015-12-18 15:58                 ` Shakthi Kannan
2015-12-18 16:10                   ` Eli Zaretskii
2015-12-30  6:22 ` Shakthi Kannan
2015-12-30 18:02   ` Eli Zaretskii
2015-12-31  0:09     ` Xue Fuqiao
2015-12-31  5:32       ` Shakthi Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y4cuz3er.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=9130@debbugs.gnu.org \
    --cc=shakthimaan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).