From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22789: 25.1.50; In last master build https connections stop working Date: Tue, 08 Mar 2016 18:40:00 +0200 Message-ID: <83y49srkin.fsf@gnu.org> References: <864mcyo14y.fsf@Lenovo-PC.i-did-not-set--mail-host-address--so-tickle-me> <834mctbitq.fsf@gnu.org> <868u25p3m2.fsf@realize.ch> <83io18ahya.fsf@gnu.org> <86y4a3on6f.fsf@realize.ch> <87oaazg7fv.fsf@gnus.org> <86twkro0vr.fsf@realize.ch> <83d1rf8ifj.fsf@gnu.org> <86povfnm9r.fsf@realize.ch> <8337sa9865.fsf@gnu.org> <86bn6ynrbw.fsf@realize.ch> <83vb566v5b.fsf@gnu.org> <83d1razkmq.fsf@gnu.org> <86egbqkwsb.fsf@realize.ch> <86a8mekjrb.fsf@realize.ch> <83k2lhxria.fsf@gnu.org> <86egbo232a.fsf@realize.ch> <83si04wx18.fsf@gnu.org> <8660wz1azm.fsf@realize.ch> <861t7n1970.fsf@realize.ch> <83mvqauv8l.fsf@gnu.org> <86bn6qylmj.fsf@realize.ch> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1457455295 30851 80.91.229.3 (8 Mar 2016 16:41:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Mar 2016 16:41:35 +0000 (UTC) Cc: larsi@gnus.org, j_l_domenech@yahoo.com, 22789@debbugs.gnu.org To: Alain Schneble Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 08 17:41:24 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adKh8-00072z-W2 for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Mar 2016 17:41:15 +0100 Original-Received: from localhost ([::1]:35824 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKh8-00041D-72 for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Mar 2016 11:41:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKh2-0003xw-6N for bug-gnu-emacs@gnu.org; Tue, 08 Mar 2016 11:41:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adKgw-0004JL-Gr for bug-gnu-emacs@gnu.org; Tue, 08 Mar 2016 11:41:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKgw-0004JH-D8 for bug-gnu-emacs@gnu.org; Tue, 08 Mar 2016 11:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1adKgw-0002up-8u for bug-gnu-emacs@gnu.org; Tue, 08 Mar 2016 11:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Mar 2016 16:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22789 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22789-submit@debbugs.gnu.org id=B22789.145745520711132 (code B ref 22789); Tue, 08 Mar 2016 16:41:02 +0000 Original-Received: (at 22789) by debbugs.gnu.org; 8 Mar 2016 16:40:07 +0000 Original-Received: from localhost ([127.0.0.1]:39925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adKg2-0002tU-NS for submit@debbugs.gnu.org; Tue, 08 Mar 2016 11:40:06 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58995) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adKfz-0002sg-2u for 22789@debbugs.gnu.org; Tue, 08 Mar 2016 11:40:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adKfo-00040S-6n for 22789@debbugs.gnu.org; Tue, 08 Mar 2016 11:39:58 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKfo-00040N-32; Tue, 08 Mar 2016 11:39:52 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2902 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1adKfn-00036v-9u; Tue, 08 Mar 2016 11:39:51 -0500 In-reply-to: <86bn6qylmj.fsf@realize.ch> (message from Alain Schneble on Mon, 7 Mar 2016 23:21:56 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114581 Archived-At: > From: Alain Schneble > CC: , , <22789@debbugs.gnu.org> > Date: Mon, 7 Mar 2016 23:21:56 +0100 > > > So we should only return EWOULDBLOCK when FILE_CONNECT is set _and_ > > the status is not STATUS_CONNECT_FAILED. If FILE_CONNECT is set, but > > the status is STATUS_CONNECT_FAILED, we should instead return the > > value computed from cp->errcode (if it is non-zero). There's an > > example of that in sys_read. > > Thank you very much for these inputs. I rearranged the patch to include > these two cases and removed another special case that should no longer > be needed as it is covered by the first one. > > Is this what you had in mind? Do you agree with the change? Yes, it looks good to me. I will test it in a couple of days. Thanks.