From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18716: Patch for this bug Date: Thu, 10 Nov 2016 19:38:57 +0200 Message-ID: <83y40rdyku.fsf@gnu.org> References: <8761fm903w.fsf@sc3d.org> <83a8d9hh62.fsf@gnu.org> <83lgwsfntd.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1478802898 19620 195.159.176.226 (10 Nov 2016 18:34:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 10 Nov 2016 18:34:58 +0000 (UTC) Cc: 18716@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 10 19:34:54 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4uBF-0002bA-NW for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Nov 2016 19:34:33 +0100 Original-Received: from localhost ([::1]:48499 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4uBI-0000p6-Ms for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Nov 2016 13:34:36 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4tKY-0001lH-CC for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2016 12:40:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4tKU-0001qz-Db for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2016 12:40:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37176) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c4tKU-0001qs-A8 for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2016 12:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c4tKU-0002EV-1D for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2016 12:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Nov 2016 17:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18716 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18716-submit@debbugs.gnu.org id=B18716.14787995498517 (code B ref 18716); Thu, 10 Nov 2016 17:40:01 +0000 Original-Received: (at 18716) by debbugs.gnu.org; 10 Nov 2016 17:39:09 +0000 Original-Received: from localhost ([127.0.0.1]:52575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4tJb-0002DG-NA for submit@debbugs.gnu.org; Thu, 10 Nov 2016 12:39:07 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4tJa-0002Cm-0c for 18716@debbugs.gnu.org; Thu, 10 Nov 2016 12:39:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4tJQ-0001GI-98 for 18716@debbugs.gnu.org; Thu, 10 Nov 2016 12:39:00 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4tJQ-0001GD-5m; Thu, 10 Nov 2016 12:38:56 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4860 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c4tJP-00047T-Al; Thu, 10 Nov 2016 12:38:55 -0500 In-reply-to: (message from Reuben Thomas on Wed, 9 Nov 2016 22:00:22 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125574 Archived-At: > From: Reuben Thomas > Date: Wed, 9 Nov 2016 22:00:22 +0000 > Cc: 18716@debbugs.gnu.org > > Sorry, I don't understand what you mean by "these are not a problem". > With your change, *.JPG files will no longer be treated like *.jpg on > Posix systems. Won't people who want *.JPG hidden complain? IOW, > isn't this change backward-incompatible? > > ​I'm confused. So am I. > I have not changed the behaviour of visiting files. I wasn't talking about visiting files. I was talking about dired-omit-mode and related Dired issues. I'm confused how visiting files entered the scene, and why. > When we talk about *.JPG files, we are not talking about dired-omit-mode, because ".jpg" is not a suffix that > would (normally) be omitted.​ I think it will be, if someone adds it to completion-ignored-extensions, or some other variable used by dired-omit-mode to set up its omitted files. > What I was trying to explain is that unexpected case-insensitivity in auto-mode-alist is not a problem, because > the user immediately sees the effects. On the other hand, in dired-omit-mode it is a problem, because the > user might not see the effects (the effects are to hide things). Yes, I understand. I was asking what do we tell users who have files they want to omit that currently are only matched because of case insensitivity. > I could add a parameter to dired-mark-unmarked-files, case-fold-p, defaulting to nil, which would be set by its > current callers. But I think you are saying that this change to the behavior of dired-omit-mode, which I have > suggested does not need a new preference, should indeed have a new preference, so I can add that too. I > think, though, that it should default to `t', i.e. dired-omit-mode behaving case-sensitively by default. Sounds like a good compromise. I agree about the default, except that it should default to case-insensitive matches on case-insensitive filesystems (Windows etc.) > > + (case-fold-search (memq system-type '(windows-nt cygwin)))) > > The list should include ms-dos as well. > > ​OK, I will add a patch for files.el, since I got the list from there, where it is used for the same purpose. If you mean set-auto-mode, then it doesn't need such a change. For obscure historical reasons, the MS-DOS port wants to be case-sensitive in that particular case (e.g., it wants to treat *.C files as C++, not C). In other places in files.el, ms-dos is already mentioned where case-insensitive file name comparison is needed. > Or perhaps there should be a global variable defined in files.el containing the list? I don't see the need. > > * lisp/dired-x.el (Commentary): Remove USAGE section explaining how to > > use dired-x from .emacs. It is now fully customizable. > > * lisp/dired-x.el (dired-guess-shell-alist-user): Remove explanation of > > how to set this custom variable in .emacs. It should be customized. > > Why remove these comments? The existence of Custom doesn't preclude > people from customizations in plain Lisp. > > The documentation is a maintenance burden (since it is hand-written and duplicate), few people will read it > anyway, and further it is redundant, since it can be customized in plain Lisp in the same way as any other > defcustom. (I presume you're not implying that we should add documentation to every Lisp source file to show > how to customize each defcustom?) Further, the documentation as it is implies that these variables *should* > be customized in plain Lisp, since (unlike most cases), there is explicit documentation about it. I don't share your interpretation of the presence of these comments, but I'm not going to start a dispute about this. Thanks.