From: Eli Zaretskii <eliz@gnu.org>
To: Reuben Thomas <rrt@sc3d.org>
Cc: 18716@debbugs.gnu.org
Subject: bug#18716: Patch for this bug
Date: Thu, 10 Nov 2016 19:38:57 +0200 [thread overview]
Message-ID: <83y40rdyku.fsf@gnu.org> (raw)
In-Reply-To: <CAOnWdogGvT6cn092PMaAmHfhHB=6bmQ=syOCqfAfAi-ncxQLNQ@mail.gmail.com> (message from Reuben Thomas on Wed, 9 Nov 2016 22:00:22 +0000)
> From: Reuben Thomas <rrt@sc3d.org>
> Date: Wed, 9 Nov 2016 22:00:22 +0000
> Cc: 18716@debbugs.gnu.org
>
> Sorry, I don't understand what you mean by "these are not a problem".
> With your change, *.JPG files will no longer be treated like *.jpg on
> Posix systems. Won't people who want *.JPG hidden complain? IOW,
> isn't this change backward-incompatible?
>
> I'm confused.
So am I.
> I have not changed the behaviour of visiting files.
I wasn't talking about visiting files. I was talking about
dired-omit-mode and related Dired issues. I'm confused how visiting
files entered the scene, and why.
> When we talk about *.JPG files, we are not talking about dired-omit-mode, because ".jpg" is not a suffix that
> would (normally) be omitted.
I think it will be, if someone adds it to
completion-ignored-extensions, or some other variable used by
dired-omit-mode to set up its omitted files.
> What I was trying to explain is that unexpected case-insensitivity in auto-mode-alist is not a problem, because
> the user immediately sees the effects. On the other hand, in dired-omit-mode it is a problem, because the
> user might not see the effects (the effects are to hide things).
Yes, I understand. I was asking what do we tell users who have files
they want to omit that currently are only matched because of case
insensitivity.
> I could add a parameter to dired-mark-unmarked-files, case-fold-p, defaulting to nil, which would be set by its
> current callers. But I think you are saying that this change to the behavior of dired-omit-mode, which I have
> suggested does not need a new preference, should indeed have a new preference, so I can add that too. I
> think, though, that it should default to `t', i.e. dired-omit-mode behaving case-sensitively by default.
Sounds like a good compromise. I agree about the default, except that
it should default to case-insensitive matches on case-insensitive
filesystems (Windows etc.)
> > + (case-fold-search (memq system-type '(windows-nt cygwin))))
>
> The list should include ms-dos as well.
>
> OK, I will add a patch for files.el, since I got the list from there, where it is used for the same purpose.
If you mean set-auto-mode, then it doesn't need such a change. For
obscure historical reasons, the MS-DOS port wants to be case-sensitive
in that particular case (e.g., it wants to treat *.C files as C++, not
C). In other places in files.el, ms-dos is already mentioned where
case-insensitive file name comparison is needed.
> Or perhaps there should be a global variable defined in files.el containing the list?
I don't see the need.
> > * lisp/dired-x.el (Commentary): Remove USAGE section explaining how to
> > use dired-x from .emacs. It is now fully customizable.
> > * lisp/dired-x.el (dired-guess-shell-alist-user): Remove explanation of
> > how to set this custom variable in .emacs. It should be customized.
>
> Why remove these comments? The existence of Custom doesn't preclude
> people from customizations in plain Lisp.
>
> The documentation is a maintenance burden (since it is hand-written and duplicate), few people will read it
> anyway, and further it is redundant, since it can be customized in plain Lisp in the same way as any other
> defcustom. (I presume you're not implying that we should add documentation to every Lisp source file to show
> how to customize each defcustom?) Further, the documentation as it is implies that these variables *should*
> be customized in plain Lisp, since (unlike most cases), there is explicit documentation about it.
I don't share your interpretation of the presence of these comments,
but I'm not going to start a dispute about this.
Thanks.
next prev parent reply other threads:[~2016-11-10 17:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 14:50 bug#18716: 24.3; dired-omit-extensions's default value omits COPYING.LIB Reuben Thomas
2014-10-14 23:41 ` Stefan Monnier
2014-10-14 23:51 ` Reuben Thomas
2014-10-15 7:56 ` Andreas Schwab
2014-10-15 14:21 ` Stefan Monnier
2014-10-15 14:26 ` Reuben Thomas
2014-10-15 14:27 ` Reuben Thomas
2014-10-15 17:59 ` Stefan Monnier
2014-10-15 19:05 ` Reuben Thomas
2014-10-15 22:42 ` Stefan Monnier
2014-10-15 23:00 ` Reuben Thomas
2014-10-16 3:10 ` Stefan Monnier
2014-10-15 14:26 ` Andreas Schwab
2014-10-15 17:57 ` Stefan Monnier
2014-10-15 20:57 ` Andreas Schwab
2014-10-15 22:44 ` Stefan Monnier
2014-10-15 22:54 ` Glenn Morris
2014-10-16 3:06 ` Stefan Monnier
2014-10-16 7:13 ` Andreas Schwab
2014-10-16 13:15 ` Stefan Monnier
2014-10-16 2:01 ` Richard Stallman
2014-10-16 3:09 ` Stefan Monnier
2014-10-16 18:14 ` Richard Stallman
2014-10-16 20:17 ` Stefan Monnier
2016-11-08 17:51 ` bug#18716: Patch for this bug Reuben Thomas
2016-11-08 20:04 ` Eli Zaretskii
2016-11-08 22:16 ` Reuben Thomas
2016-11-09 19:36 ` Eli Zaretskii
2016-11-09 22:00 ` Reuben Thomas
2016-11-09 22:52 ` Drew Adams
2016-11-09 23:29 ` Reuben Thomas
2016-11-10 17:38 ` Eli Zaretskii [this message]
2016-11-26 17:54 ` Reuben Thomas
2016-11-26 18:29 ` Ken Brown
2016-11-28 21:32 ` Reuben Thomas
2016-12-02 9:40 ` Eli Zaretskii
2016-12-02 16:10 ` Reuben Thomas
2016-12-02 16:16 ` Eli Zaretskii
2016-12-02 16:31 ` Reuben Thomas
2016-12-03 0:22 ` bug#18716: Reuben Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y40rdyku.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=18716@debbugs.gnu.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).