From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25890: `color-values` gives wrong value Date: Fri, 10 Mar 2017 11:28:47 +0200 Message-ID: <83y3wdeb00.fsf@gnu.org> References: <87zih7n2yt.fsf@pank.eu> <83a88tfv4a.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1489138213 32292 195.159.176.226 (10 Mar 2017 09:30:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Mar 2017 09:30:13 +0000 (UTC) Cc: 25890@debbugs.gnu.org To: "mail\@yo.eki.do" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 10 10:30:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmGsA-0007rs-GZ for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Mar 2017 10:30:06 +0100 Original-Received: from localhost ([::1]:38151 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmGsG-000578-LZ for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Mar 2017 04:30:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmGsB-00055q-H7 for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2017 04:30:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmGs7-00060n-Dk for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2017 04:30:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50292) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cmGs7-00060j-9u for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2017 04:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cmGs7-0007f4-3P for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2017 04:30:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Mar 2017 09:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25890 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25890-submit@debbugs.gnu.org id=B25890.148913815929371 (code B ref 25890); Fri, 10 Mar 2017 09:30:03 +0000 Original-Received: (at 25890) by debbugs.gnu.org; 10 Mar 2017 09:29:19 +0000 Original-Received: from localhost ([127.0.0.1]:48491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmGrO-0007de-SD for submit@debbugs.gnu.org; Fri, 10 Mar 2017 04:29:19 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cmGrN-0007dQ-31 for 25890@debbugs.gnu.org; Fri, 10 Mar 2017 04:29:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cmGrD-0005lI-VI for 25890@debbugs.gnu.org; Fri, 10 Mar 2017 04:29:12 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cmGrD-0005lE-S3; Fri, 10 Mar 2017 04:29:07 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3834 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cmGrD-0000ps-6k; Fri, 10 Mar 2017 04:29:07 -0500 In-reply-to: (mail@yo.eki.do) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130430 Archived-At: > From: "mail@yo.eki.do" > Date: Fri, 10 Mar 2017 08:33:59 +0000 > > This change will have too large impacts since the number of parameters > will change. > Indeed developers can use the optional argument, but that trick won't > work in the previous version of Emacs and will lead to > wrong-number-of-arguments errors, > so they will need burdensome workarounds e.g. version check. Packages that need to support older versions of Emacs will have to provide a wrapper function that indeed looks at emacs-version. That's nothing new. > I'd have to say that the default argument should stick to 2, the original. That would leave the original problem in place, so I don't think it's acceptable.