From: Eli Zaretskii <eliz@gnu.org>
To: Werner LEMBERG <wl@gnu.org>
Cc: 25945-done@debbugs.gnu.org
Subject: bug#25945: Emacs aborts while calling FT_Load_Glyph
Date: Tue, 11 Apr 2017 13:08:08 +0300 [thread overview]
Message-ID: <83y3v7jlyv.fsf@gnu.org> (raw)
In-Reply-To: <20170303.080429.592950574985497052.wl@gnu.org> (message from Werner LEMBERG on Fri, 03 Mar 2017 08:04:29 +0100 (CET))
> Date: Fri, 03 Mar 2017 08:04:29 +0100 (CET)
> From: Werner LEMBERG <wl@gnu.org>
>
> For me, Emacs aborts at ftfont.c:1550 while `mew' tries to display an
> e-mail.
>
> 1549 if (FT_Load_Glyph (ft_face, g->g.code, FT_LOAD_DEFAULT) != 0)
> 1550 emacs_abort ();
>
> Examining `ft_face' and `g->g.code' I see that the font in question is
> `Padauk Book Bold' (PadaukBook-Bold.ttf), glyph 376. Examining this
> font further with `ftview' I see that bytecode of this font is broken,
> and that the font can only be displayed successfully without bytecode.
> [This is version 3.002 of the font, taken from the current TeXLive
> repository.]
>
> I think there is no reason that Emacs aborts for such broken fonts.
> Instead I suggest that (a) Emacs tries to load the glyph again without
> hinting, and (b) if that fails, it should display a missing glyph,
> using the standard rectangle with hex digits in it.
>
> New code for (a) is quite simple:
>
> if (FT_Load_Glyph (ft_face, g->g.code, FT_LOAD_DEFAULT) != 0)
> if (FT_Load_Glyph (ft_face, g->g.code, FT_LOAD_NO_HINTING) != 0)
> ...
Thanks, I've now pushed this change to the Emacs master branch, and
I'm marking this bug done.
prev parent reply other threads:[~2017-04-11 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 7:04 bug#25945: Emacs aborts while calling FT_Load_Glyph Werner LEMBERG
2017-03-03 8:08 ` Eli Zaretskii
2017-03-03 8:32 ` Werner LEMBERG
2017-03-03 8:43 ` Eli Zaretskii
2017-03-03 10:37 ` Werner LEMBERG
2017-03-03 13:43 ` Eli Zaretskii
2017-03-04 5:39 ` Werner LEMBERG
2017-03-04 9:32 ` Eli Zaretskii
2017-03-11 19:08 ` Eli Zaretskii
2017-04-11 10:08 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y3v7jlyv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=25945-done@debbugs.gnu.org \
--cc=wl@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).