* bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving
@ 2014-12-10 22:15 Dmitry Gutov
2014-12-15 12:01 ` Dmitry Gutov
0 siblings, 1 reply; 13+ messages in thread
From: Dmitry Gutov @ 2014-12-10 22:15 UTC (permalink / raw)
To: 19343
1. Open vc-dir for the repository with an unregistered file.
2. Open the file in Emacs, modify, save.
3. See it become `up-to-date' in the vc-dir buffer.
4. Switch to vc-dir, press `g'. See it become `unregistered' again.
Apparently, in part it's a result of how bug#11757 was resolved (see the
comment at the top of `vc-git-state'), but I don't remember seeing this
problem before Emacs 25. Yet I don't see anything specific among the
recent changes that caused it.
Maybe `vc-git-state' should call `git status --short' instead of `git
diff-index'.
In GNU Emacs 25.0.50.3 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
of 2014-12-10 on axl
Repository revision: bdc373bf456de464b44836b11826705c0aef70b1
Windowing system distributor `The X.Org Foundation', version 11.0.11501000
System Description: Ubuntu 14.04.1 LTS
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving
2014-12-10 22:15 bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving Dmitry Gutov
@ 2014-12-15 12:01 ` Dmitry Gutov
2014-12-17 4:28 ` Dmitry Gutov
0 siblings, 1 reply; 13+ messages in thread
From: Dmitry Gutov @ 2014-12-15 12:01 UTC (permalink / raw)
To: 19343
Dmitry Gutov <dgutov@yandex.ru> writes:
> but I don't remember seeing this problem before Emacs 25
Correction: it's also present in `emacs-24' and even 24.3.
So it's quite possible that the problem was introduced while fixing the
aforementioned bug.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving
2014-12-15 12:01 ` Dmitry Gutov
@ 2014-12-17 4:28 ` Dmitry Gutov
2014-12-17 13:19 ` Dmitry Gutov
0 siblings, 1 reply; 13+ messages in thread
From: Dmitry Gutov @ 2014-12-17 4:28 UTC (permalink / raw)
To: 19343
Looking though
https://git.kernel.org/cgit/git/git.git/tree/Documentation/RelNotes,
'git status --short' was introduced in 1.7.0.
What's our minimum version?
Starting with 1.7.6.2, we can also use `git status --ignored', to list
files in all major states. This can help with an old FIXME in
`vc-git-state' about it never returning `ignored', and also radically
simplify (and speed up) `vc-git-dir-status-files'.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving
2014-12-17 4:28 ` Dmitry Gutov
@ 2014-12-17 13:19 ` Dmitry Gutov
2014-12-17 15:40 ` Eli Zaretskii
0 siblings, 1 reply; 13+ messages in thread
From: Dmitry Gutov @ 2014-12-17 13:19 UTC (permalink / raw)
To: 19343
> What's our minimum version?
Debian Stable has 1.7.10.4, but CentOS 6 - only 1.7.1.
So apparently we can use `status --short' (or rather --porcelain), but
--ignored is no-go for now.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving
2014-12-17 13:19 ` Dmitry Gutov
@ 2014-12-17 15:40 ` Eli Zaretskii
2014-12-17 17:11 ` Dmitry Gutov
2017-05-01 1:36 ` Dmitry Gutov
0 siblings, 2 replies; 13+ messages in thread
From: Eli Zaretskii @ 2014-12-17 15:40 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 19343
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Wed, 17 Dec 2014 15:19:27 +0200
>
> > What's our minimum version?
>
> Debian Stable has 1.7.10.4, but CentOS 6 - only 1.7.1.
>
> So apparently we can use `status --short' (or rather --porcelain), but
> --ignored is no-go for now.
Why can't we use --ignored when it's available? It doesn't feel right
to me to punish users of newer versions just because someone else out
there might not have such a version.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving
2014-12-17 15:40 ` Eli Zaretskii
@ 2014-12-17 17:11 ` Dmitry Gutov
2014-12-17 18:15 ` Eli Zaretskii
2017-05-01 1:36 ` Dmitry Gutov
1 sibling, 1 reply; 13+ messages in thread
From: Dmitry Gutov @ 2014-12-17 17:11 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 19343
On 12/17/2014 05:40 PM, Eli Zaretskii wrote:
> Why can't we use --ignored when it's available? It doesn't feel right
> to me to punish users of newer versions just because someone else out
> there might not have such a version.
Sure we can, it's just more code complexity to support different code paths.
Considering there hasn't been many user complaints about either issue
(vc-git-state never returns `ignored'; vc-git-dir-status-files is slower
that it could be), maybe that's not worth it. Waiting a few years would
be easier.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving
2014-12-17 17:11 ` Dmitry Gutov
@ 2014-12-17 18:15 ` Eli Zaretskii
0 siblings, 0 replies; 13+ messages in thread
From: Eli Zaretskii @ 2014-12-17 18:15 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 19343
> Date: Wed, 17 Dec 2014 19:11:03 +0200
> From: Dmitry Gutov <dgutov@yandex.ru>
> CC: 19343@debbugs.gnu.org
>
> On 12/17/2014 05:40 PM, Eli Zaretskii wrote:
>
> > Why can't we use --ignored when it's available? It doesn't feel right
> > to me to punish users of newer versions just because someone else out
> > there might not have such a version.
>
> Sure we can, it's just more code complexity to support different code paths.
>
> Considering there hasn't been many user complaints about either issue
> (vc-git-state never returns `ignored'; vc-git-dir-status-files is slower
> that it could be), maybe that's not worth it. Waiting a few years would
> be easier.
It's up to you, I just wanted to raise the possibility.
Thanks.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving
2014-12-17 15:40 ` Eli Zaretskii
2014-12-17 17:11 ` Dmitry Gutov
@ 2017-05-01 1:36 ` Dmitry Gutov
2017-05-01 7:10 ` Eli Zaretskii
1 sibling, 1 reply; 13+ messages in thread
From: Dmitry Gutov @ 2017-05-01 1:36 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 19343-done
On 17.12.2014 17:40, Eli Zaretskii wrote:
>>> What's our minimum version?
>>
>> Debian Stable has 1.7.10.4, but CentOS 6 - only 1.7.1.
>>
>> So apparently we can use `status --short' (or rather --porcelain), but
>> --ignored is no-go for now.
>
> Why can't we use --ignored when it's available? It doesn't feel right
> to me to punish users of newer versions just because someone else out
> there might not have such a version.
I've just pushed a patch (24301c8148f5f3220d7e597c73a59551cfa10eea)
which fixes this bug, and also uses ---ignored, because that's how the
Jonathan wrote it.
Do we still care about CentOS 6? The previous message in this discussion
has been more than 2 years ago.
If so, we can remove --ignored from the call in vc-git-state, it's not
hugely important there. It will be more important when we decide to
reimplement vc-git-status-files in the same fashion, though.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving
2017-05-01 1:36 ` Dmitry Gutov
@ 2017-05-01 7:10 ` Eli Zaretskii
2017-05-01 15:00 ` Dmitry Gutov
0 siblings, 1 reply; 13+ messages in thread
From: Eli Zaretskii @ 2017-05-01 7:10 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 19343
> Cc: 19343-done@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Mon, 1 May 2017 04:36:13 +0300
>
> > Why can't we use --ignored when it's available? It doesn't feel right
> > to me to punish users of newer versions just because someone else out
> > there might not have such a version.
>
> I've just pushed a patch (24301c8148f5f3220d7e597c73a59551cfa10eea)
> which fixes this bug, and also uses ---ignored, because that's how the
> Jonathan wrote it.
Thanks.
> Do we still care about CentOS 6?
I don't know. According to my references, it will be maintained until
2021 at least, possibly as late as 2024. If that's true, then yes, we
should care.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving
2017-05-01 7:10 ` Eli Zaretskii
@ 2017-05-01 15:00 ` Dmitry Gutov
2017-05-01 15:14 ` Eli Zaretskii
0 siblings, 1 reply; 13+ messages in thread
From: Dmitry Gutov @ 2017-05-01 15:00 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 19343
On 01.05.2017 10:10, Eli Zaretskii wrote:
>> Do we still care about CentOS 6?
>
> I don't know. According to my references, it will be maintained until
> 2021 at least, possibly as late as 2024. If that's true, then yes, we
> should care.
OK, thanks. I've removed the --ignored flag. Which brings back a related
bug with ignored files.
Fortunately, ignored files are rarely displayed in vc-dir buffers, so
it's less of a problem.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving
2017-05-01 15:00 ` Dmitry Gutov
@ 2017-05-01 15:14 ` Eli Zaretskii
2017-05-01 16:55 ` Dmitry Gutov
0 siblings, 1 reply; 13+ messages in thread
From: Eli Zaretskii @ 2017-05-01 15:14 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 19343
> Cc: 19343@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Mon, 1 May 2017 18:00:52 +0300
>
> On 01.05.2017 10:10, Eli Zaretskii wrote:
>
> >> Do we still care about CentOS 6?
> >
> > I don't know. According to my references, it will be maintained until
> > 2021 at least, possibly as late as 2024. If that's true, then yes, we
> > should care.
>
> OK, thanks. I've removed the --ignored flag. Which brings back a related
> bug with ignored files.
I don't think that's what I had in mind. I thought about probing for
that flag once, then using it if it's available.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving
2017-05-01 15:14 ` Eli Zaretskii
@ 2017-05-01 16:55 ` Dmitry Gutov
2017-05-01 19:09 ` Eli Zaretskii
0 siblings, 1 reply; 13+ messages in thread
From: Dmitry Gutov @ 2017-05-01 16:55 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 19343
On 01.05.2017 18:14, Eli Zaretskii wrote:
> I don't think that's what I had in mind. I thought about probing for
> that flag once, then using it if it's available.
Very well, I've added a version check.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving
2017-05-01 16:55 ` Dmitry Gutov
@ 2017-05-01 19:09 ` Eli Zaretskii
0 siblings, 0 replies; 13+ messages in thread
From: Eli Zaretskii @ 2017-05-01 19:09 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 19343
> Cc: 19343@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Mon, 1 May 2017 19:55:03 +0300
>
> On 01.05.2017 18:14, Eli Zaretskii wrote:
>
> > I don't think that's what I had in mind. I thought about probing for
> > that flag once, then using it if it's available.
>
> Very well, I've added a version check.
Great, thanks!
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2017-05-01 19:09 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-10 22:15 bug#19343: 25.0.50; [vc-git] Unregistered file becomes `up-to-date' in vc-dir buffer after editing and saving Dmitry Gutov
2014-12-15 12:01 ` Dmitry Gutov
2014-12-17 4:28 ` Dmitry Gutov
2014-12-17 13:19 ` Dmitry Gutov
2014-12-17 15:40 ` Eli Zaretskii
2014-12-17 17:11 ` Dmitry Gutov
2014-12-17 18:15 ` Eli Zaretskii
2017-05-01 1:36 ` Dmitry Gutov
2017-05-01 7:10 ` Eli Zaretskii
2017-05-01 15:00 ` Dmitry Gutov
2017-05-01 15:14 ` Eli Zaretskii
2017-05-01 16:55 ` Dmitry Gutov
2017-05-01 19:09 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).