From: Eli Zaretskii <eliz@gnu.org>
To: charles@aurox.ch (Charles A. Roelli)
Cc: 28350@debbugs.gnu.org
Subject: bug#28350: enriched.el code execution
Date: Sun, 10 Sep 2017 20:01:20 +0300 [thread overview]
Message-ID: <83y3pmtrmn.fsf@gnu.org> (raw)
In-Reply-To: <m260cra9rq.fsf@aurox.ch> (charles@aurox.ch)
> Date: Sat, 09 Sep 2017 22:37:29 +0200
> From: charles@aurox.ch (Charles A. Roelli)
> CC: 28350@debbugs.gnu.org
>
> Thank you. I've kept the current approach. Please see again the
> attached patch.
Some minor nits below.
> Also, should the left-fringe/right-fringe display specifications be
> considered safe? They seem innocuous.
Yes, I think so. And your patch already does allow them, doesn't it?
> +(defcustom enriched-allow-unsafe-display-props nil
> + "Variable determining whether to decode arbitrary display properties.
"If non-nil allow to evaluate arbitrary forms in display properties."
> + :risky t
> + :type 'boolean
> + :group 'enriched)
Please add :version here. Please also add a short NEWS entry.
It would be good to have tests for this, but doing that is much less
urgent than fixing the vulnerability, so please feel free to do so as
a separate commit (unless you already have the tests ready).
Otherwise, looks good to me. Thanks.
next prev parent reply other threads:[~2017-09-10 17:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 19:24 bug#28350: enriched.el code execution Charles A. Roelli
2017-09-06 19:25 ` Charles A. Roelli
2017-09-07 2:34 ` Eli Zaretskii
2017-09-09 12:23 ` Charles A. Roelli
2017-09-09 13:45 ` Eli Zaretskii
2017-09-09 15:57 ` Charles A. Roelli
2017-09-09 16:55 ` Eli Zaretskii
2017-09-09 20:37 ` Charles A. Roelli
2017-09-10 17:01 ` Eli Zaretskii [this message]
2017-09-11 16:32 ` Glenn Morris
2017-09-11 17:01 ` Eli Zaretskii
2017-09-09 22:43 ` Paul Eggert
2017-09-10 18:54 ` Charles A. Roelli
2017-09-10 21:46 ` Paul Eggert
2017-09-11 2:39 ` Eli Zaretskii
2017-09-11 14:22 ` Eli Zaretskii
2017-09-11 15:18 ` Eli Zaretskii
2017-09-11 18:44 ` Charles A. Roelli
2017-09-11 19:07 ` Eli Zaretskii
2017-09-16 9:48 ` Eli Zaretskii
2017-09-11 15:33 ` Glenn Morris
2017-09-11 16:38 ` Paul Eggert
2017-09-11 21:16 ` Glenn Morris
2017-09-12 19:59 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y3pmtrmn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=28350@debbugs.gnu.org \
--cc=charles@aurox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).