From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28814: [BUMP, PATCH] (26.0.90; When *xref* window is needed, original window-switching intent is lost ) Date: Thu, 26 Oct 2017 19:42:44 +0300 Message-ID: <83y3nx7tdn.fsf@gnu.org> References: <87infjm3p3.fsf@gmail.com> <871slyi3lk.fsf_-_@gmail.com> <87lgk22ryu.fsf@gmail.com> <87fua91vis.fsf@gmail.com> <13af136e-12fb-4e8d-81ff-63424b1e1943@yandex.ru> <83inf38dq2.fsf@gnu.org> <87k1zjs0xa.fsf@gmail.com> <83fua78ce9.fsf@gnu.org> <87a80fvte2.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1509036260 13991 195.159.176.226 (26 Oct 2017 16:44:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 26 Oct 2017 16:44:20 +0000 (UTC) Cc: 28814@debbugs.gnu.org, dgutov@yandex.ru To: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 26 18:44:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7lGH-0002FI-9n for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Oct 2017 18:44:05 +0200 Original-Received: from localhost ([::1]:53858 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7lGO-0006oE-EJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Oct 2017 12:44:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7lGI-0006o7-S6 for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2017 12:44:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7lGF-0002JE-OZ for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2017 12:44:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54895) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e7lGF-0002J7-KI for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2017 12:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e7lGD-0007Ww-Uj for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2017 12:44:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Oct 2017 16:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28814 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28814-submit@debbugs.gnu.org id=B28814.150903618828874 (code B ref 28814); Thu, 26 Oct 2017 16:44:01 +0000 Original-Received: (at 28814) by debbugs.gnu.org; 26 Oct 2017 16:43:08 +0000 Original-Received: from localhost ([127.0.0.1]:35343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7lFL-0007Vd-OF for submit@debbugs.gnu.org; Thu, 26 Oct 2017 12:43:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7lFJ-0007VA-OH for 28814@debbugs.gnu.org; Thu, 26 Oct 2017 12:43:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7lF9-0001wY-NJ for 28814@debbugs.gnu.org; Thu, 26 Oct 2017 12:43:00 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7lF9-0001wU-K1; Thu, 26 Oct 2017 12:42:55 -0400 Original-Received: from [176.228.60.248] (port=2234 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e7lF8-00079w-VE; Thu, 26 Oct 2017 12:42:55 -0400 In-reply-to: <87a80fvte2.fsf@gmail.com> (joaotavora@gmail.com) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139020 Archived-At: > From: joaotavora@gmail.com (João Távora) > Cc: dgutov@yandex.ru, 28814@debbugs.gnu.org > Date: Wed, 25 Oct 2017 21:56:21 +0100 > > > How about 'Q'? > > OK. I used 'Q'. And added 'TAB'. Because it's a bit what happens in > completion, which also selects and quits the transient completions > window. If Dmitry doesn't like 'Q', I'm not wedded to it. Feel free to change the keybinding. > >> It’s a bugfix, so emacs-26. > > > > I'd need to see the patches in their last incarnation (if you already > > posted them, and nothing needs to be changed, a URL will be > > appreciated). In general, this changes user-visible behavior in > > non-trivial ways, so it's borderline between a bugfix and a new > > feature. But if the patches are small and simple enough, I guess they > > could be okay for emacs-26. > > Let's hope they are. Attached are 4 patches. The 2 first are part of the > bugfix. Number 3 is the new xref-quit-and-goto-xref and number 4 are > documentation changes to the .texi manual (also fixed a small bug there) > and NEWS. Thanks. What can I say? the patches are really not trivial, and I hesitate to put them on emacs-26. During development of Emacs 25 it took us some time and effort to stabilize these features, so I'd hate to destabilize them now because of some unintended consequence we don't currently envision. OTOH, we are only at the first pretest. Dmitry, what's your opinion? A few comments to the documentation: . Please proofread the text for UK English spellings (e.g., "honour") and only one space between sentences. . I don't understand the reason for such extensive changes in the manual. Most of them look purely stylistic, and I see no problems with the original text to justify that. What did I miss? . I don't see a need for a NEWS entry. If this is a bugfix, then it doesn't belong there, as we don't describe bugfixes in NEWS (there are too many to describe).