From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode) Date: Mon, 06 Nov 2017 17:59:50 +0200 Message-ID: <83y3njs8i1.fsf@gnu.org> References: <87y3nka4ez.fsf@t-online.de> <87wp34a2i1.fsf@t-online.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1509985321 24157 195.159.176.226 (6 Nov 2017 16:22:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 6 Nov 2017 16:22:01 +0000 (UTC) Cc: 29150@debbugs.gnu.org To: Olaf Rogalsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 06 17:21:54 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBk9q-000629-06 for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Nov 2017 17:21:54 +0100 Original-Received: from localhost ([::1]:48971 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBk9x-0001la-8u for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Nov 2017 11:22:01 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBjon-0000TD-57 for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 11:00:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBjoh-00066E-Ej for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 11:00:09 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45729) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBjoh-00065x-Bd for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 11:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eBjoh-000270-1M for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 11:00:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Nov 2017 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29150 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29150-submit@debbugs.gnu.org id=B29150.15099839988078 (code B ref 29150); Mon, 06 Nov 2017 16:00:02 +0000 Original-Received: (at 29150) by debbugs.gnu.org; 6 Nov 2017 15:59:58 +0000 Original-Received: from localhost ([127.0.0.1]:54410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBjoc-00026D-13 for submit@debbugs.gnu.org; Mon, 06 Nov 2017 10:59:58 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBjoZ-00025y-Rz for 29150@debbugs.gnu.org; Mon, 06 Nov 2017 10:59:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBjoP-0005ws-HX for 29150@debbugs.gnu.org; Mon, 06 Nov 2017 10:59:50 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBjoP-0005wn-E9; Mon, 06 Nov 2017 10:59:45 -0500 Original-Received: from [176.228.60.248] (port=2876 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eBjoO-0007mx-7C; Mon, 06 Nov 2017 10:59:45 -0500 In-reply-to: <87wp34a2i1.fsf@t-online.de> (message from Olaf Rogalsky on Sun, 05 Nov 2017 21:34:30 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139507 Archived-At: > From: Olaf Rogalsky > Date: Sun, 05 Nov 2017 21:34:30 +0100 > > in case of a button down event, `describe-key' has some trickery to also > read the forthcoming up event. The following patch makes this trickery > work with xterm-mouse-mode. Thanks. Do you understand why read-key-sequence-vector works with xt-mouse, while read-event doesn't? If so, can you elaborate on that? Also, I take it that you assume there will be only one element in the array returned by read-key-sequence-vector, is that right? If so, how sure are we that this will always be the case? Because if the assumption could be false, this change will have Emacs wait for some other input, and the user might think that Emacs hanged. Anyway, in general, I'm wary of such changes, which replace one API for reading input by another, which works subtly differently. We had in the recent past several incidents where similar changes seemed to work, only to reveal many moons later that some rarely-used but useful functionality stopped working or became semi-broken. So I think I'd prefer a fix that is specific to xt-mouse (assuming that we can reliably detect that the clicks come from xt-mouse), and leave the other use cases alone. If such a solution is possible and makes sense, we could even install it on the release branch. > PS: It would be nice, if that person also can have a look at patch #29104 It's in my queue, if no one else beats me to it. And there, too, more detailed description of what you saw and what led you to your proposed solution might go a long way towards admitting the change sooner.