unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: p.stephani2@gmail.com
Cc: 30460@debbugs.gnu.org
Subject: bug#30460: 27.0.50; `process-command' of a stopped process is t
Date: Sat, 17 Feb 2018 15:25:50 +0200	[thread overview]
Message-ID: <83y3jrbvdt.fsf@gnu.org> (raw)
In-Reply-To: <wvr4tvuj5j0l.fsf@a.muc.corp.google.com> (p.stephani2@gmail.com)

> Date: Wed, 14 Feb 2018 23:00:26 +0100
> From: p.stephani2@gmail.com
> 
> 
> (process-command
>    (make-process :name "sleep" :command '("sleep" "1h") :stop t))
> 
> returns t.
> 
> This is not documented (the docstring and the manual say that this
> should only happen for a pipe, network, or serial connection), and
> breaks M-x list-processes, which assumes that the return value of
> `process-command' is a list for an ordinary process.

":stop t" currently has no effect on a "real" process running a
command, because it is not generally possible to start a process in a
stopped state.  So it's a Good Thing list-processes fails for such
bogus "processes" ;-)

We could fix this by either ignoring :stop in make-process, or by
signaling an error.  The simplest change is just delete this snipper
from Fmake_process:

  if (tem = Fplist_get (contact, QCstop), !NILP (tem))
    pset_command (XPROCESS (proc), Qt);

The correct command was already set by that time, so the above just
overwrites the correct expected value.





  reply	other threads:[~2018-02-17 13:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 22:00 bug#30460: 27.0.50; `process-command' of a stopped process is t p.stephani2
2018-02-17 13:25 ` Eli Zaretskii [this message]
2019-04-19 11:05   ` Philipp Stephani
2019-04-19 11:06     ` bug#30460: [PATCH] Remove :stop key from make-process Philipp Stephani
2019-04-19 11:26       ` Eli Zaretskii
2019-04-19 12:15         ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y3jrbvdt.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=30460@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).