From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30190: 27.0.50; term run in line mode shows user passwords Date: Sat, 10 Mar 2018 14:07:07 +0200 Message-ID: <83y3j0t9qs.fsf@gnu.org> References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <83a7vgut17.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1520683570 8942 195.159.176.226 (10 Mar 2018 12:06:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Mar 2018 12:06:10 +0000 (UTC) Cc: 30190@debbugs.gnu.org, rms@gnu.org, npostavs@users.sourceforge.net To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 10 13:06:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eudGH-0002FE-Vq for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Mar 2018 13:06:06 +0100 Original-Received: from localhost ([::1]:50407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eudIK-0004PC-RE for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Mar 2018 07:08:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eudIE-0004Ov-IO for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 07:08:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eudIA-0003eb-HU for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 07:08:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45288) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eudIA-0003eX-Dw for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 07:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eudIA-0003MX-8S for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 07:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Mar 2018 12:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed security Original-Received: via spool by 30190-submit@debbugs.gnu.org id=B30190.152068365812889 (code B ref 30190); Sat, 10 Mar 2018 12:08:02 +0000 Original-Received: (at 30190) by debbugs.gnu.org; 10 Mar 2018 12:07:38 +0000 Original-Received: from localhost ([127.0.0.1]:53185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eudHl-0003Lo-VA for submit@debbugs.gnu.org; Sat, 10 Mar 2018 07:07:38 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:37534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eudHj-0003La-QV for 30190@debbugs.gnu.org; Sat, 10 Mar 2018 07:07:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eudHa-0003XR-Ob for 30190@debbugs.gnu.org; Sat, 10 Mar 2018 07:07:30 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eudHP-0003VY-26; Sat, 10 Mar 2018 07:07:15 -0500 Original-Received: from [176.228.60.248] (port=3050 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eudHH-00088k-28; Sat, 10 Mar 2018 07:07:07 -0500 In-reply-to: (message from Tino Calancha on Sat, 10 Mar 2018 19:44:13 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144105 Archived-At: > From: Tino Calancha > Date: Sat, 10 Mar 2018 19:44:13 +0900 (JST) > cc: Tino Calancha , 30190@debbugs.gnu.org, > rms@gnu.org, npostavs@users.sourceforge.net > > > . it uses many constructs in term-password-prompt-regexp that could > > happen in unrelated text--does that mean such unrelated text will > > become invisible, thus making the session at least look buggy? > Regarding this issue, it would behave exactly as a dumb shell buffer does > M-x shell RET > I've never seen a bug report about that for comint.el. If you see that, > you should definitely open a bug report! > > > The 2nd issue looks to me like a more serious one, unless I'm missing > > something. Is it possible to make sure we don't mistakenly take some > > innocent text as a password? Did you try in your testing to type text > > that matches this regexp, and if so, what did you see as result? > > I tried just after I read your message. I don't find a problem. Can you please show some examples? First, what text triggers the new functionality correctly, when the user types a password at some relevant prompt, and then what happens when an unrelated prompt is taken by the filter function as a prompt for a password. I'd like to understand better what happens in each case. > And as a pointed out above, it uses the same mechanism as comint.el > (e.g. dumb shell buffers), so I don't think you should worry about > it. Sorry, this doesn't really tell me enough, because I don't think I understand the relevance of dumb shells and comint to the issue at hand. Thanks.