From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17250: 24.3; find-variable gives search-failed error message Date: Wed, 18 Apr 2018 09:23:40 +0300 Message-ID: <83y3hl118z.fsf@gnu.org> References: <87y4zaiuz7.fsf@bredband.net> <87zi21e8yo.fsf@mouse.gnus.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1524032529 21673 195.159.176.226 (18 Apr 2018 06:22:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 18 Apr 2018 06:22:09 +0000 (UTC) Cc: 17250@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 18 08:22:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8gTl-0005ZP-93 for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Apr 2018 08:22:05 +0200 Original-Received: from localhost ([::1]:33999 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8gVs-0006Ep-2u for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Apr 2018 02:24:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8gVh-0006D2-TS for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 02:24:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8gVd-0007Yg-Sv for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 02:24:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50484) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8gVd-0007YZ-Op for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 02:24:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8gVd-0006vS-IT for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 02:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Apr 2018 06:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17250 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 17250-submit@debbugs.gnu.org id=B17250.152403262926604 (code B ref 17250); Wed, 18 Apr 2018 06:24:01 +0000 Original-Received: (at 17250) by debbugs.gnu.org; 18 Apr 2018 06:23:49 +0000 Original-Received: from localhost ([127.0.0.1]:58381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8gVN-0006uz-DN for submit@debbugs.gnu.org; Wed, 18 Apr 2018 02:23:48 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8gVI-0006uh-Qm for 17250@debbugs.gnu.org; Wed, 18 Apr 2018 02:23:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8gV9-0007QN-P0 for 17250@debbugs.gnu.org; Wed, 18 Apr 2018 02:23:35 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8gV9-0007QI-K4; Wed, 18 Apr 2018 02:23:31 -0400 Original-Received: from [176.228.60.248] (port=3366 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f8gV8-0003hJ-OG; Wed, 18 Apr 2018 02:23:31 -0400 In-reply-to: <87zi21e8yo.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Wed, 18 Apr 2018 00:58:39 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145555 Archived-At: > From: Lars Ingebrigtsen > Date: Wed, 18 Apr 2018 00:58:39 +0200 > Cc: 17250@debbugs.gnu.org > > But there are several places that use this function without checking the > return value. Are they relying on this function to bug out with a > cryptic error, or are they all confident that the file name can be > found? > > So I haven't applied it yet. Perhaps somebody else will weigh in... I'm not weighing in ;-) > (defun help-C-file-name (subr-or-var kind) > "Return the name of the C file where SUBR-OR-VAR is defined. > -KIND should be `var' for a variable or `subr' for a subroutine." > +KIND should be `var' for a variable or `subr' for a subroutine. > +If we can't find the file name, nil is returned." ^^^^^^^^^^^^^^^ "return nil". We try to avoid passive tense.