From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31754: 25.1; etags output lacks info for making xref more useful Date: Mon, 11 Jun 2018 20:46:09 +0300 Message-ID: <83y3flp672.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1528739399 25085 195.159.176.226 (11 Jun 2018 17:49:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 11 Jun 2018 17:49:59 +0000 (UTC) Cc: 31754@debbugs.gnu.org To: Gauthier =?UTF-8?Q?=C3=96stervall?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 11 19:49:55 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSQx0-0006Rq-Ny for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Jun 2018 19:49:54 +0200 Original-Received: from localhost ([::1]:50584 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSQz7-0001A6-QM for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Jun 2018 13:52:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSQuI-0005SU-37 for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 13:47:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSQuD-0001iB-Vq for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 13:47:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35753) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSQuD-0001i4-S5 for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 13:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fSQuD-00070W-IU for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 13:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jun 2018 17:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31754 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31754-submit@debbugs.gnu.org id=B31754.152873918526894 (code B ref 31754); Mon, 11 Jun 2018 17:47:01 +0000 Original-Received: (at 31754) by debbugs.gnu.org; 11 Jun 2018 17:46:25 +0000 Original-Received: from localhost ([127.0.0.1]:43650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSQtd-0006zh-Ci for submit@debbugs.gnu.org; Mon, 11 Jun 2018 13:46:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSQta-0006zU-VO for 31754@debbugs.gnu.org; Mon, 11 Jun 2018 13:46:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSQtR-0001QA-Qs for 31754@debbugs.gnu.org; Mon, 11 Jun 2018 13:46:17 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSQtG-0001MM-He; Mon, 11 Jun 2018 13:46:02 -0400 Original-Received: from [176.228.60.248] (port=2334 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fSQtF-0006TD-Oh; Mon, 11 Jun 2018 13:46:02 -0400 In-reply-to: (message from Gauthier =?UTF-8?Q?=C3=96stervall?= on Fri, 8 Jun 2018 11:21:54 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147300 Archived-At: severity 31754 wishlist thanks > From: Gauthier Östervall > Date: Fri, 8 Jun 2018 11:21:54 +0200 > > Given the following code: > > ---8<--- > int my_identifier(int a) { > return 2 * a; > } > > int my_identifier(int a, int b) { > return a + b; > } > ---8<--- > > and a TAGS file generated with etags (no options). > > Running xref-find-definitions (M-.) opens a suggestion buffer with this content: > > ---8<--- > /home/gauthier/tmp/xref.c > 1: int my_identifier( > 5: int my_identifier( > ---8<--- > > This could be more helpful, the suggestions are not distinguishable. I > suggest including at least the whole source row. I originally thought that etags should be extended to include the while line in TAGS, at least as an option, but the more I think about this, the less I'm convinced thats the right approach. For starters, no one said that line will show enough to tell the difference. For example, imagine this code: int my_identifier(int a, int b) { return 2 * a + b; } int my_identifier(int a, int b, double fac) { return fac*a + b; } So now I think that perhaps we should leave etags alone, and instead add a feature to xref whereby the lines in the XREF buffer will show in a tooltip the full signature of the function. Any takers?