From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32512: xref--read-identifier using etags backend should honor case-fold-search Date: Thu, 23 Aug 2018 20:29:55 +0300 Message-ID: <83y3cx9ejw.fsf@gnu.org> References: <4a1f6a0a6772940a66f0efd389535d96@ludovic-brenta.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1535046383 19273 195.159.176.226 (23 Aug 2018 17:46:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 23 Aug 2018 17:46:23 +0000 (UTC) Cc: 32512@debbugs.gnu.org To: Ludovic Brenta Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 23 19:46:18 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fstgY-0004uF-Ij for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 Aug 2018 19:46:18 +0200 Original-Received: from localhost ([::1]:38122 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fstif-0000BX-0X for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 Aug 2018 13:48:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fstRr-0004PN-0m for bug-gnu-emacs@gnu.org; Thu, 23 Aug 2018 13:31:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fstRm-0003Xt-0A for bug-gnu-emacs@gnu.org; Thu, 23 Aug 2018 13:31:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54059) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fstRl-0003Xj-S8 for bug-gnu-emacs@gnu.org; Thu, 23 Aug 2018 13:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fstRl-00023A-Ok for bug-gnu-emacs@gnu.org; Thu, 23 Aug 2018 13:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Aug 2018 17:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32512 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32512-submit@debbugs.gnu.org id=B32512.15350454247835 (code B ref 32512); Thu, 23 Aug 2018 17:31:01 +0000 Original-Received: (at 32512) by debbugs.gnu.org; 23 Aug 2018 17:30:24 +0000 Original-Received: from localhost ([127.0.0.1]:59077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fstR9-00022J-QJ for submit@debbugs.gnu.org; Thu, 23 Aug 2018 13:30:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fstR7-000223-LQ for 32512@debbugs.gnu.org; Thu, 23 Aug 2018 13:30:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fstQx-0002pv-E9 for 32512@debbugs.gnu.org; Thu, 23 Aug 2018 13:30:16 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fstQx-0002pd-9E; Thu, 23 Aug 2018 13:30:11 -0400 Original-Received: from [176.228.60.248] (port=1957 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fstQw-0000SG-S4; Thu, 23 Aug 2018 13:30:11 -0400 In-reply-to: <4a1f6a0a6772940a66f0efd389535d96@ludovic-brenta.org> (message from Ludovic Brenta on Thu, 23 Aug 2018 17:11:18 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149700 Archived-At: > Date: Thu, 23 Aug 2018 17:11:18 +0100 > From: Ludovic Brenta > > (a) > M-. foo.bar/b => jumps to foo-bar.adb line 1, "package Foo.Bar is". > > but > > (b) > M-. foo.bar => "no match" > > In (a), xref-find-definition took whatever my input was and honored > case-fold-search, which is t, to find the definition of the package. > > But when I type asking for possible completions, > xref--read-identifier > is case-sensitive whether I like it or not. Indeed: > > (c) > M-. Foo.Bar => produces the desired completion Foo.Bar/b > > The inconsistency between (a) and (b) is anti-ergonomic. > > I looked for a variable, separate from case-fold-search, that would > control the case sensitivity of completion in this case, but I couldn't > find one. I think one of explicit goals of Xref development was to make it much more accurate than etags is, which is why it explicitly disables some loose match methods etags offers (and was using when its front-end was invoked by M-.). With that in mind, folding case would go against that goal, so I'm not sure it's a step in the right direction. Is the problem the inconsistency between (a) and (b), or is the problem that you _want_ xref-find-definition to be case-insensitive? If the former, perhaps we should instead make (a) fail as well? Thanks.