From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Fri, 14 Dec 2018 15:42:49 +0200 Message-ID: <83y38sfcme.fsf@gnu.org> References: <20181213203102.GF2244@macbook.localdomain> <83h8fghcpo.fsf@gnu.org> <20181214075056.GI2244@macbook.localdomain> <8336r0h1cb.fsf@gnu.org> <20181214110316.GK2244@macbook.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1544795197 26957 195.159.176.226 (14 Dec 2018 13:46:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 14 Dec 2018 13:46:37 +0000 (UTC) Cc: behdad@behdad.org, kaushal.modi@gmail.com, 33729@debbugs.gnu.org, far.nasiri.m@gmail.com To: Khaled Hosny Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 14 14:46:32 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXnnU-0006vT-Hw for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Dec 2018 14:46:32 +0100 Original-Received: from localhost ([::1]:33621 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXnpb-0006Je-71 for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Dec 2018 08:48:43 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXnl7-0002jz-Tj for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 08:44:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXnl4-0006MG-NQ for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 08:44:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43173) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXnl4-0006MA-G8 for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 08:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gXnl4-000799-CI for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 08:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Dec 2018 13:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33729-submit@debbugs.gnu.org id=B33729.154479498627391 (code B ref 33729); Fri, 14 Dec 2018 13:44:02 +0000 Original-Received: (at 33729) by debbugs.gnu.org; 14 Dec 2018 13:43:06 +0000 Original-Received: from localhost ([127.0.0.1]:47431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXnkA-00077i-5X for submit@debbugs.gnu.org; Fri, 14 Dec 2018 08:43:06 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXnk9-00077B-2o for 33729@debbugs.gnu.org; Fri, 14 Dec 2018 08:43:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXnk2-0005nx-TB for 33729@debbugs.gnu.org; Fri, 14 Dec 2018 08:42:59 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXnjz-0005m6-5s; Fri, 14 Dec 2018 08:42:55 -0500 Original-Received: from [176.228.60.248] (port=1640 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gXnjy-0001de-JB; Fri, 14 Dec 2018 08:42:55 -0500 In-reply-to: <20181214110316.GK2244@macbook.localdomain> (message from Khaled Hosny on Fri, 14 Dec 2018 13:03:16 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153447 Archived-At: > Date: Fri, 14 Dec 2018 13:03:16 +0200 > From: Khaled Hosny > Cc: kaushal.modi@gmail.com, behdad@behdad.org, 33729@debbugs.gnu.org, > far.nasiri.m@gmail.com > > > FWIW, I looked at ftfont.c:uni_script, and I cannot find a problem > > with it; in particular looking up in char-script-table each character > > of the Gujarati welcome in HELLO yields 'gujarati', so I couldn't see > > any evident Emacs issue. Or are you saying that hb_script_from_string > > doesn't DTRT? Or maybe Kaushal should upgrade to a newer version of > > HarfBuzz? > > There is this FIXME: > > /* FIXME: from_string wants an ISO 15924 script tag here. */ > > As we discussed earlier, hb_script_from_string() expects ISO 15924 > script tags, but char_script_table does not provide such tags (I don’t > recall what it does provide exactly). We need a way to get ISO 15924 > script tags from Emacs. Right, I forgot about that. So you are saying that we need to generate Gujr instead of gujarati, is that right? Mohammad, do you need help in comping up with a solution? There's otf-script-alist (see fontest.el), but it goes in the opposite direction. We could use rassq (Frassq in C) to find the OTF script tag by its Emacs symbol (which is returned by indexing into Vchar_script_table), by looking in otf-script-alist. Or maybe you prefer a seperat data structure, not limited to the OTF tags? Let me know if you need more help.