From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: michael_heerdegen@web.de, 34179@debbugs.gnu.org
Subject: bug#34179: 27.0.50; message hangs when buffer with process visible
Date: Fri, 25 Jan 2019 12:15:14 +0200 [thread overview]
Message-ID: <83y37959hp.fsf@gnu.org> (raw)
In-Reply-To: <5C4ADA96.4010400@gmx.at> (message from martin rudalics on Fri, 25 Jan 2019 10:44:54 +0100)
> Date: Fri, 25 Jan 2019 10:44:54 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: 34179@debbugs.gnu.org
>
> >> #0 redisplay_other_windows () at xdisp.c:597
> >> #1 0x010aa09e in select_window (window=XIL(0xa000000006919aa0),
> >> norecord=XIL(0x3d36a14), inhibit_point_swap=false) at window.c:540
> >> #2 0x010aa62a in Fselect_window (window=XIL(0xa000000006919aa0),
> >> norecord=XIL(0x3d36a14)) at window.c:628
> >
> > To clarify: these backtraces show where windows_or_buffers_changed is
> > being set to the value of 2, which causes us to retry redisplay. It
> > is a direct consequence of the fact that window-max-chars-per-line
> > calls select-window.
>
> If I replace the line
>
> (with-selected-window (window-normalize-window window t)
>
> of 'window-max-chars-per-line' by the line
>
> (with-current-buffer (window-buffer window)
>
> the problem persists. So it is not the 'select-window' call per se
> that causes the trouble.
That's because both selecting a window and changing its buffer sets
windows_or_buffers_changed via redisplay_other_windows.
> The problem is with having that separate frame that gets its echo
> area resized.
What separate frame?
> Using 'window-size-change-functions' (patch attached) instead of
> 'window-configuration-change-hook' fixes the problem here.
That might be a good change anyway, but the more general problem of
having an easily triggered infloop in redisplay_internal remains, and
we should fix that, IMO.
Let me turn the table and ask: why do we need to retry redisplay when
some function called from run_window_change_functions does something
that requires redisplay? Why not leave that to the next redisplay
cycle?
next prev parent reply other threads:[~2019-01-25 10:15 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 15:10 bug#34179: 27.0.50; message hangs when buffer with process visible Michael Heerdegen
2019-01-23 16:29 ` Eli Zaretskii
2019-01-24 13:19 ` Michael Heerdegen
2019-01-24 13:35 ` Michael Heerdegen
2019-01-24 14:39 ` Eli Zaretskii
2019-01-24 14:58 ` Michael Heerdegen
2019-01-24 15:04 ` Michael Heerdegen
2019-01-24 15:25 ` Michael Heerdegen
2019-01-24 15:36 ` Michael Heerdegen
2019-01-24 16:05 ` martin rudalics
2019-01-24 18:22 ` Michael Heerdegen
2019-01-24 18:33 ` martin rudalics
2019-01-24 18:36 ` Eli Zaretskii
2019-01-24 18:51 ` martin rudalics
2019-01-24 18:59 ` Eli Zaretskii
2019-01-24 19:20 ` Michael Heerdegen
2019-01-24 18:55 ` Michael Heerdegen
2019-01-24 18:47 ` Michael Heerdegen
2019-01-24 19:21 ` Eli Zaretskii
2019-01-24 19:49 ` Eli Zaretskii
2019-01-25 9:44 ` martin rudalics
2019-01-25 10:15 ` Eli Zaretskii [this message]
2019-01-25 10:36 ` martin rudalics
2019-01-25 13:32 ` Eli Zaretskii
2019-01-25 16:51 ` martin rudalics
2019-01-25 17:22 ` martin rudalics
2019-01-26 12:58 ` Michael Heerdegen
2019-01-26 15:09 ` martin rudalics
2019-01-26 18:48 ` martin rudalics
2019-01-27 14:22 ` Michael Heerdegen
2019-01-28 18:38 ` martin rudalics
2019-01-30 22:29 ` Michael Heerdegen
2019-01-31 8:32 ` martin rudalics
2019-01-31 14:06 ` Eli Zaretskii
2019-01-31 18:44 ` martin rudalics
2019-01-31 20:10 ` Eli Zaretskii
2019-02-01 9:04 ` martin rudalics
2019-01-31 14:44 ` Michael Heerdegen
2019-02-02 9:28 ` martin rudalics
2019-02-04 23:35 ` Michael Heerdegen
2019-02-19 8:39 ` martin rudalics
2019-01-25 18:31 ` Eli Zaretskii
2019-01-25 18:54 ` martin rudalics
2019-01-25 19:48 ` Eli Zaretskii
2019-01-24 15:46 ` martin rudalics
2019-01-24 14:32 ` Eli Zaretskii
2019-01-24 14:41 ` Michael Heerdegen
2019-01-24 14:49 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y37959hp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=34179@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).