From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34723: 27.0.50; customize and improve diff-mode recentering Date: Tue, 05 Mar 2019 18:11:57 +0200 Message-ID: <83y35tcnci.fsf@gnu.org> References: <87o96rprs3.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="205299"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34723@debbugs.gnu.org, juri@linkov.net To: charles@aurox.ch Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 05 17:13:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1Cgu-000rHH-Nc for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Mar 2019 17:13:16 +0100 Original-Received: from localhost ([127.0.0.1]:45191 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1Cgt-0001PD-Kv for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Mar 2019 11:13:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1Cgn-0001OW-CS for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 11:13:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1Cgj-00049Q-A3 for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 11:13:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48056) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1Cgg-000456-As for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 11:13:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h1Cgg-0006uW-5E for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2019 11:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Mar 2019 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34723 X-GNU-PR-Package: emacs Original-Received: via spool by 34723-submit@debbugs.gnu.org id=B34723.155180233626494 (code B ref 34723); Tue, 05 Mar 2019 16:13:02 +0000 Original-Received: (at 34723) by debbugs.gnu.org; 5 Mar 2019 16:12:16 +0000 Original-Received: from localhost ([127.0.0.1]:33367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1Cfv-0006tG-OJ for submit@debbugs.gnu.org; Tue, 05 Mar 2019 11:12:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1Cfu-0006sz-A1 for 34723@debbugs.gnu.org; Tue, 05 Mar 2019 11:12:14 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1Cfi-00032o-QS; Tue, 05 Mar 2019 11:12:07 -0500 Original-Received: from [176.228.60.248] (port=2910 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h1Cff-0005rS-OG; Tue, 05 Mar 2019 11:12:01 -0500 In-reply-to: (charles@aurox.ch) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156058 Archived-At: > Date: Mon, 04 Mar 2019 20:06:13 +0100 > From: charles@aurox.ch (Charles A. Roelli) > Cc: 34723@debbugs.gnu.org > > > (setq isearch-push-state-function > > (lambda () > > (when (and isearch-success (not (pos-visible-in-window-p))) > > (reposition-window)) > > `(lambda (cmd) > > (when isearch-success > > (set-window-start nil ,(window-start)))))) > > Can we add something like this to isearch.el, maybe as a defcustom? > Or maybe we could add it in a way such that other packages that show > search results (grep, xref) could use the same function to reposition > the window. The function could inspect a defcustom in simple.el to > decide whether (or how) to reposition the window. Isn't it easier to temporarily bind scroll-margin to a non-zero value, then force redisplay? Or maybe I'm missing something in this discussion.