From: Eli Zaretskii <eliz@gnu.org>
To: charles@aurox.ch
Cc: 34723@debbugs.gnu.org, juri@linkov.net
Subject: bug#34723: 27.0.50; customize and improve diff-mode recentering
Date: Tue, 05 Mar 2019 18:11:57 +0200 [thread overview]
Message-ID: <83y35tcnci.fsf@gnu.org> (raw)
In-Reply-To: <m2d0n6v4re.fsf@aurox.ch> (charles@aurox.ch)
> Date: Mon, 04 Mar 2019 20:06:13 +0100
> From: charles@aurox.ch (Charles A. Roelli)
> Cc: 34723@debbugs.gnu.org
>
> > (setq isearch-push-state-function
> > (lambda ()
> > (when (and isearch-success (not (pos-visible-in-window-p)))
> > (reposition-window))
> > `(lambda (cmd)
> > (when isearch-success
> > (set-window-start nil ,(window-start))))))
>
> Can we add something like this to isearch.el, maybe as a defcustom?
> Or maybe we could add it in a way such that other packages that show
> search results (grep, xref) could use the same function to reposition
> the window. The function could inspect a defcustom in simple.el to
> decide whether (or how) to reposition the window.
Isn't it easier to temporarily bind scroll-margin to a non-zero value,
then force redisplay?
Or maybe I'm missing something in this discussion.
next prev parent reply other threads:[~2019-03-05 16:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 20:38 bug#34723: 27.0.50; customize and improve diff-mode recentering Charles A. Roelli
2019-03-03 21:33 ` Juri Linkov
2019-03-04 19:06 ` Charles A. Roelli
2019-03-04 21:12 ` Juri Linkov
2019-03-05 16:11 ` Eli Zaretskii [this message]
2019-03-05 20:11 ` Charles A. Roelli
2019-03-05 20:22 ` Eli Zaretskii
2019-03-07 19:12 ` Charles A. Roelli
2019-03-05 15:46 ` Eli Zaretskii
2019-03-05 19:49 ` Charles A. Roelli
2019-03-05 19:44 ` Eli Zaretskii
2019-03-05 20:37 ` Charles A. Roelli
2019-03-06 16:06 ` Eli Zaretskii
2019-03-07 19:49 ` Charles A. Roelli
2019-03-13 19:40 ` Stefan Monnier
2019-03-13 19:56 ` Stefan Monnier
2019-03-16 19:39 ` Charles A. Roelli
2019-03-16 22:37 ` Stefan Monnier
2019-03-16 20:21 ` Charles A. Roelli
2019-03-22 19:32 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y35tcnci.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=34723@debbugs.gnu.org \
--cc=charles@aurox.ch \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).